Date: Fri, 26 Jun 2009 00:37:24 +0100
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Ribeiro <drwyrm@gmail.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
       linux-kernel <linux-kernel@vger.kernel.org>,
       openezx-devel <openezx-devel@lists.openezx.org>,
       Samuel Ortiz <sameo@linux.intel.com>
Message-ID: <20090625233723.GA13150@sirena.org.uk>
References: <1245961793.10360.26.camel@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1245961793.10360.26.camel@brutus>
User-Agent: Mutt/1.5.20 (2009-06-14)
Subject: Re: [PATCH] PCAP regulator driver (for 2.6.32).
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1002
Lines: 22

On Thu, Jun 25, 2009 at 05:29:53PM -0300, Daniel Ribeiro wrote:

> +	/*
> +	 * The regulator framework doesn't like regulators which default
> +	 * to ON at boot time, so we just disable it here (when it is safe).
> +	 */
> +	if (pdev->id == VAUX2 || pdev->id == VAUX3)
> +		pcap_regulator_disable(rdev);

No need to do this - the regulator framework is perfectly happy with
regulators that are enabled at boot time and turning regulators that are
actively being used off is likely to cause issues.  Regulator drivers
should just leave everything as they find it and leave it up to the core
and machine drivers to make any changes.

Other than that this looks good; I'm assuming the PCAP core has a
sensible way of getting the platform data to the devices.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/