Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753517AbZFZHhd (ORCPT ); Fri, 26 Jun 2009 03:37:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751312AbZFZHh0 (ORCPT ); Fri, 26 Jun 2009 03:37:26 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:38403 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750699AbZFZHhZ (ORCPT ); Fri, 26 Jun 2009 03:37:25 -0400 Date: Fri, 26 Jun 2009 10:37:25 +0300 (EEST) From: Pekka J Enberg To: "Pallipadi, Venkatesh" cc: Andrew Morton , "linux-kernel@vger.kernel.org" , "rjw@sisk.pl" , mingo@elte.hu, cl@linux-foundation.org, npiggin@suse.de, a.p.zijlstra@chello.nl Subject: Re: possible recursive locking detected at kmem_cache_free In-Reply-To: <20090625215541.GB29401@linux-os.sc.intel.com> Message-ID: References: <20090625185942.GA29401@linux-os.sc.intel.com> <20090625123750.734b7f50.akpm@linux-foundation.org> <20090625215541.GB29401@linux-os.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1437 Lines: 50 Hi Venki, On Thu, 25 Jun 2009, Pallipadi, Venkatesh wrote: > > > Not sure if this has been reported elsewhere. I started seeing this with git > > > kernel from this morning on a system with RedHat EL5 base installation with > > > ext3 root file system. Attached is the config I am using. > > > > > > Let me know if you need any more details. This seems to be at every boot. I > > > am trying the bisect right now. > > > > > > > Thanks. Let's cc Pekka. > > > > git bisect result. Thanks! I think I just broke lockdep annotations for slab. Does this patch fix things? Pekka diff --git a/mm/slab.c b/mm/slab.c index e74a16e..37ee532 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -1544,9 +1544,6 @@ void __init kmem_cache_init(void) } g_cpucache_up = EARLY; - - /* Annotate slab for lockdep -- annotate the malloc caches */ - init_lock_keys(); } void __init kmem_cache_init_late(void) @@ -1563,6 +1560,9 @@ void __init kmem_cache_init_late(void) /* Done! */ g_cpucache_up = FULL; + /* Annotate slab for lockdep -- annotate the malloc caches */ + init_lock_keys(); + /* * Register a cpu startup notifier callback that initializes * cpu_cache_get for all new cpus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/