Date: Fri, 26 Jun 2009 10:13:10 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       "H. Peter Anvin" <hpa@linux.intel.com>
Subject: Re: [PATCH 3/9] x86/moorestown: add moorestown platform flags
Message-ID: <20090626101310.4110a290@lxorguk.ukuu.org.uk>
In-Reply-To: <20090626071955.GG14078@elte.hu>
References: <43F901BD926A4E43B106BF17856F07556412B7E2@orsmsx508.amr.corp.intel.com>
	<20090626071955.GG14078@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1050
Lines: 24

> Why dont we have some clean and robust PCI config space based 
> enumeration instead of this boot ID based thing?

That strikes me as a rather dumb question given that 

- Embedded x86 like devices are going to regularly occur without any PCI
- You need to know the platform in order to know how to access any PCI
  bus that may or may not hypothetically exist.

Take a look at how ARM and PPC address this. They do it via platform
features and descriptors for good reason.

One thing PPC does nice is to encapsulate pretty much all of it into a
struct of function pointers for each platform to keep the if conditionals
down. The ARM file layout of arch/foo/platform/bar might also be a good
idea before mrst and olpc and other stuff like this starts to make the
main x86 directory hard to read ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/