DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=jMQIsZrJCc0h5cCk0kH3GcEnDQ0YcInCTvoI509xDVtnNr3iTRi9sdU6+9+5PMmLYSeuQWDzimE44qoKR99Hk32HzZXaVVepw7/JER0SOg/mnESQ9e9l55Fdu81ycqNB;
Date: Fri, 26 Jun 2009 09:51:19 -0700
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       "H. Peter Anvin" <hpa@linux.intel.com>
Subject: Re: [PATCH 3/9] x86/moorestown: add moorestown platform flags
Message-ID: <20090626095119.15067a53@jbarnes-g45>
In-Reply-To: <20090626071955.GG14078@elte.hu>
References: <43F901BD926A4E43B106BF17856F07556412B7E2@orsmsx508.amr.corp.intel.com>
	<20090626071955.GG14078@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1075
Lines: 30

On Fri, 26 Jun 2009 09:19:55 +0200
Ingo Molnar <mingo@elte.hu> wrote:
> >  void platform_feature_init_default(int subarch_id)
> >  {
> > -	printk(KERN_INFO "Use default X86 platform feature set\n");
> > +	if ((subarch_id >= 0) && (subarch_id < N_X86_SUBARCHS)) {
> > +		if (subarch_id == X86_SUBARCH_MRST) {
> > +			setup_mrst_default_feature();
> > +			return;
> > +		}
> > +	} else {
> > +		printk(KERN_INFO "Use default X86 platform feature
> > set\n");
> > +	}
> >  }
> 
> Why dont we have some clean and robust PCI config space based 
> enumeration instead of this boot ID based thing?

MRST has special PCI support that depends on having the platform
identified already, so if you want to use something other than a flag
here, maybe we could use an SFI string instead.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/