Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760964AbZFZSRn (ORCPT ); Fri, 26 Jun 2009 14:17:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753561AbZFZSRe (ORCPT ); Fri, 26 Jun 2009 14:17:34 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:46575 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbZFZSRd (ORCPT ); Fri, 26 Jun 2009 14:17:33 -0400 Date: Fri, 26 Jun 2009 11:17:38 -0700 (PDT) Message-Id: <20090626.111738.141246987.davem@davemloft.net> To: davidel@xmailserver.org Cc: oleg@redhat.com, eric.dumazet@gmail.com, jolsa@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, fbl@redhat.com, nhorman@redhat.com, htejun@gmail.com Subject: Re: [PATCH] net: fix race in the receive/select From: David Miller In-Reply-To: References: <20090626145027.GA6534@redhat.com> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 26 From: Davide Libenzi Date: Fri, 26 Jun 2009 11:12:15 -0700 (PDT) > On Fri, 26 Jun 2009, Oleg Nesterov wrote: > >> Perhaps we can add >> >> void sock_poll_wait(struct file *file, struct sock *sk, poll_table *pt) >> { >> if (pt) { >> poll_wait(file, sk->sk_sleep, pt); >> /* >> * fat comment >> */ >> smp_mb(); // or smp_mb__after_unlock(); >> } >> } > > That'd be fine IMHO. Are DaveM and Eric OK? No objections from me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/