Message-ID: <4A451BA4.4090000@linux.intel.com>
Date: Fri, 26 Jun 2009 12:04:04 -0700
From: "H. Peter Anvin" <hpa@linux.intel.com>
Organization: Intel Open Source Technology Center
User-Agent: Thunderbird 2.0.0.21 (X11/20090320)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/9] x86: introduce a set of platform feature flags
References: <43F901BD926A4E43B106BF17856F07556412B7E1@orsmsx508.amr.corp.intel.com> <20090626154731.GA3153@elte.hu>
In-Reply-To: <20090626154731.GA3153@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1099
Lines: 28

Ingo Molnar wrote:
> 
> Btw., this enumeration of basic PC features isnt bad in itself - and 
> if there's a boot-flag based detection method (like on MRST) then 
> this can convey a 'should this platform driver attempt to 
> initialize' information to the driver, and rather cleanly so.
> 

That is the whole point of this, yes.  Furthermore, it is expected that
we *also* would be able to set platform flags based on early probes.

> But there's bad uses of this as well, and those bad uses seem to 
> dominate this patch-set.

Not entirely surprising, since this stuff is more or less randomly
sprinkled through the existing code.  We have a huge bunch of legacy
code and yes, it needs cleanup.

This is a huge opportunity, of course, but it's going to be a lot of
work.  A lot of this is likely to overlap directly with the needs of
Xen, too.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/