Message-ID: <4A452300.5080507@gmail.com>
Date: Fri, 26 Jun 2009 21:35:28 +0200
From: Eric Dumazet <eric.dumazet@gmail.com>
User-Agent: Thunderbird 2.0.0.22 (Windows/20090605)
MIME-Version: 1.0
To: jolsa@redhat.com
CC: David Miller <davem@davemloft.net>, davidel@xmailserver.org,
       oleg@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       fbl@redhat.com, nhorman@redhat.com, htejun@gmail.com
Subject: Re: [PATCH] net: fix race in the receive/select
References: <alpine.DEB.1.10.0906261018580.16400@makko.or.mcafeemobile.com>	<20090626145027.GA6534@redhat.com>	<alpine.DEB.1.10.0906261111230.16400@makko.or.mcafeemobile.com> <20090626.111738.141246987.davem@davemloft.net>
In-Reply-To: <20090626.111738.141246987.davem@davemloft.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 910
Lines: 35

David Miller a ?crit :
> From: Davide Libenzi <davidel@xmailserver.org>
> Date: Fri, 26 Jun 2009 11:12:15 -0700 (PDT)
> 
>> On Fri, 26 Jun 2009, Oleg Nesterov wrote:
>>
>>> Perhaps we can add
>>>
>>> 	void sock_poll_wait(struct file *file, struct sock *sk, poll_table *pt)
>>> 	{
>>> 		if (pt) {
>>> 			poll_wait(file, sk->sk_sleep, pt);
>>> 			/*
>>> 			 * fat comment
>>> 			 */
>>> 			smp_mb(); // or smp_mb__after_unlock();
>>> 		}
>>> 	}
>> That'd be fine IMHO. Are DaveM and Eric OK?
> 
> No objections from me.

Very good :)

Jiri, please respin a patch with this idea from Oleg

(We'll have to check all calls to poll_wait() in net tree)

Thanks everybody

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/