Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761560AbZFZVrR (ORCPT ); Fri, 26 Jun 2009 17:47:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751287AbZFZVrG (ORCPT ); Fri, 26 Jun 2009 17:47:06 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:44649 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbZFZVrG (ORCPT ); Fri, 26 Jun 2009 17:47:06 -0400 To: "Pan\, Jacob jun" Cc: Ingo Molnar , Jeremy Fitzhardinge , "linux-kernel\@vger.kernel.org" , "H. Peter Anvin" References: <43F901BD926A4E43B106BF17856F07556412B7E7@orsmsx508.amr.corp.intel.com> <20090626071725.GE14078@elte.hu> <43F901BD926A4E43B106BF17856F0755641A46AA@orsmsx508.amr.corp.intel.com> From: ebiederm@xmission.com (Eric W. Biederman) Date: Fri, 26 Jun 2009 14:47:01 -0700 In-Reply-To: <43F901BD926A4E43B106BF17856F0755641A46AA@orsmsx508.amr.corp.intel.com> (Jacob jun Pan's message of "Fri\, 26 Jun 2009 13\:59\:02 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in01.mta.xmission.com;;;ip=76.21.114.89;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 76.21.114.89 X-SA-Exim-Rcpt-To: jacob.jun.pan@intel.com, hpa@linux.intel.com, linux-kernel@vger.kernel.org, jeremy@goop.org, mingo@elte.hu X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;"Pan\, Jacob jun" X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral * 0.4 UNTRUSTED_Relay Comes from a non-trusted relay Subject: Re: [PATCH 8/9] x86/apic: match destination id with destination mode X-SA-Exim-Version: 4.2.1 (built Thu, 25 Oct 2007 00:26:12 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 22 "Pan, Jacob jun" writes: > [[JPAN]] For Moorestown production silicon, we will use apic_default which uses > logical dest mode. This patch is not required. > But, I think it is wrong to assign destination ID without looking at the mode > bit. If we have a new apic_xxxx with phy dest mode, we would have logical APIC > ID assigned to physical mode. Both phys dest and logical dest use the same bits in the apic. The code that assigns the destination knows which mode we are operating in. Even not supporting logical mode is likely ok. The key thing is doing the work in the auto detect logic and not doing something weird in the assignments. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/