Date: Sat, 27 Jun 2009 16:13:04 -0400 (EDT)
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@redhat.com>
cc: Ingo Molnar <mingo@elte.hu>,
       Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
       lkml <linux-kernel@vger.kernel.org>,
       systemtap <systemtap@sources.redhat.com>,
       DLE <dle-develop@lists.sourceforge.net>,
       Jim Keniston <jkenisto@us.ibm.com>,
       Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
       Christoph Hellwig <hch@infradead.org>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       "H. Peter Anvin" <hpa@zytor.com>, Anders Kaseorg <andersk@ksplice.com>,
       Tim Abbott <tabbott@ksplice.com>, sam@ravnborg.org
Subject: Re: [RFC][ PATCH -tip v2 3/7] Kbuild: disable gcc crossjumping
In-Reply-To: <20090622212313.5384.84166.stgit@localhost.localdomain>
Message-ID: <alpine.DEB.2.00.0906271611280.12592@gandalf.stny.rr.com>
References: <20090622212255.5384.53732.stgit@localhost.localdomain> <20090622212313.5384.84166.stgit@localhost.localdomain>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2367
Lines: 78


A change like this requires an ACK from Sam Ravnborg.

-- Steve


On Mon, 22 Jun 2009, Masami Hiramatsu wrote:

> Add CONFIG_DISABLE_CROSSJUMP option which disables gcc's cross-function
> jumping. This option is required by the kprobes jump optimization.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Jim Keniston <jkenisto@us.ibm.com>
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Anders Kaseorg <andersk@ksplice.com>
> Cc: Tim Abbott <tabbott@ksplice.com>
> ---
> 
>  Makefile          |    4 ++++
>  lib/Kconfig.debug |    7 +++++++
>  2 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 2903e13..f73b139 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -524,6 +524,10 @@ else
>  KBUILD_CFLAGS	+= -O2
>  endif
>  
> +ifdef CONFIG_DISABLE_CROSSJUMP
> +KBUILD_CFLAGS	+= -fno-crossjumping
> +endif
> +
>  include $(srctree)/arch/$(SRCARCH)/Makefile
>  
>  ifneq ($(CONFIG_FRAME_WARN),0)
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 8da7467..f88e6b8 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -673,6 +673,13 @@ config FRAME_POINTER
>  	  larger and slower, but it gives very useful debugging information
>  	  in case of kernel bugs. (precise oopses/stacktraces/warnings)
>  
> +config DISABLE_CROSSJUMP
> +	bool "Disable cross-function jump optimization"
> +	help
> +	  This build option disables cross-function jump optimization
> +	  (crossjumping) of gcc. Disabling crossjumping might increase
> +	  kernel binary size a little.
> +
>  config BOOT_PRINTK_DELAY
>  	bool "Delay each boot printk message by N milliseconds"
>  	depends on DEBUG_KERNEL && PRINTK && GENERIC_CALIBRATE_DELAY
> 
> 
> -- 
> Masami Hiramatsu
> 
> Software Engineer
> Hitachi Computer Products (America), Inc.
> Software Solutions Division
> 
> e-mail: mhiramat@redhat.com
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/