Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753012AbZF1LnV (ORCPT ); Sun, 28 Jun 2009 07:43:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752294AbZF1LnH (ORCPT ); Sun, 28 Jun 2009 07:43:07 -0400 Received: from khc.piap.pl ([195.187.100.11]:60796 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbZF1LnG (ORCPT ); Sun, 28 Jun 2009 07:43:06 -0400 To: Joe Perches Cc: linux-kernel@vger.kernel.org, Kevin Curtis , netdev@vger.kernel.org Subject: Re: [PATCH 10/19] drivers/net/wan: Use PCI_VDEVICE References: From: Krzysztof Halasa Date: Sun, 28 Jun 2009 13:43:04 +0200 In-Reply-To: (Joe Perches's message of "Wed\, 24 Jun 2009 22\:13\:26 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2224 Lines: 58 Joe Perches writes: > Signed-off-by: Joe Perches > --- > drivers/net/wan/farsync.c | 21 +++++++-------------- > drivers/net/wan/pc300_drv.c | 12 ++++++------ > drivers/net/wan/pc300too.c | 12 ++++-------- > drivers/net/wan/wanxl.c | 9 +++------ > 4 files changed, 20 insertions(+), 34 deletions(-) Looks good. Though I guess I'd delete these now unnecessary empty lines if I were you: > +++ b/drivers/net/wan/farsync.c > @@ -528,26 +528,19 @@ static int fst_debug_mask = { FST_DEBUG }; > * PCI ID lookup table > */ > static struct pci_device_id fst_pci_dev_id[] __devinitdata = { > - {PCI_VENDOR_ID_FARSITE, PCI_DEVICE_ID_FARSITE_T2P, PCI_ANY_ID, > - PCI_ANY_ID, 0, 0, FST_TYPE_T2P}, > + {PCI_VDEVICE(FARSITE, PCI_DEVICE_ID_FARSITE_T2P), FST_TYPE_T2P}, > > - {PCI_VENDOR_ID_FARSITE, PCI_DEVICE_ID_FARSITE_T4P, PCI_ANY_ID, > - PCI_ANY_ID, 0, 0, FST_TYPE_T4P}, > + {PCI_VDEVICE(FARSITE, PCI_DEVICE_ID_FARSITE_T4P), FST_TYPE_T4P}, > > - {PCI_VENDOR_ID_FARSITE, PCI_DEVICE_ID_FARSITE_T1U, PCI_ANY_ID, > - PCI_ANY_ID, 0, 0, FST_TYPE_T1U}, > + {PCI_VDEVICE(FARSITE, PCI_DEVICE_ID_FARSITE_T1U), FST_TYPE_T1U}, > > - {PCI_VENDOR_ID_FARSITE, PCI_DEVICE_ID_FARSITE_T2U, PCI_ANY_ID, > - PCI_ANY_ID, 0, 0, FST_TYPE_T2U}, > + {PCI_VDEVICE(FARSITE, PCI_DEVICE_ID_FARSITE_T2U), FST_TYPE_T2U}, > > - {PCI_VENDOR_ID_FARSITE, PCI_DEVICE_ID_FARSITE_T4U, PCI_ANY_ID, > - PCI_ANY_ID, 0, 0, FST_TYPE_T4U}, > + {PCI_VDEVICE(FARSITE, PCI_DEVICE_ID_FARSITE_T4U), FST_TYPE_T4U}, > > - {PCI_VENDOR_ID_FARSITE, PCI_DEVICE_ID_FARSITE_TE1, PCI_ANY_ID, > - PCI_ANY_ID, 0, 0, FST_TYPE_TE1}, > + {PCI_VDEVICE(FARSITE, PCI_DEVICE_ID_FARSITE_TE1), FST_TYPE_TE1}, > > - {PCI_VENDOR_ID_FARSITE, PCI_DEVICE_ID_FARSITE_TE1C, PCI_ANY_ID, > - PCI_ANY_ID, 0, 0, FST_TYPE_TE1}, > + {PCI_VDEVICE(FARSITE, PCI_DEVICE_ID_FARSITE_TE1C), FST_TYPE_TE1}, > {0,} /* End */ > }; The rest of WAN bits - ack. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/