Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753799AbZF1NwT (ORCPT ); Sun, 28 Jun 2009 09:52:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752665AbZF1NwG (ORCPT ); Sun, 28 Jun 2009 09:52:06 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:53985 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbZF1NwF (ORCPT ); Sun, 28 Jun 2009 09:52:05 -0400 Subject: Re: [PATCH] SCSI: userspace cannot use scsi_command_size_tbl, COMMAND_SIZE and scsi_device_type From: James Bottomley To: Jaswinder Singh Rajput Cc: Matthew Wilcox , Sam Ravnborg , Boaz Harrosh , Benny Halevy , LKML , linux-scsi , James Smart In-Reply-To: <1246128039.32198.17.camel@hpdv5.satnam> References: <1246122359.32198.7.camel@hpdv5.satnam> <1246123628.3990.19.camel@mulgrave.site> <1246125388.32198.14.camel@hpdv5.satnam> <20090627182821.GC5480@parisc-linux.org> <1246128039.32198.17.camel@hpdv5.satnam> Content-Type: text/plain Date: Sun, 28 Jun 2009 08:52:04 -0500 Message-Id: <1246197124.4190.5.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1872 Lines: 51 On Sun, 2009-06-28 at 00:10 +0530, Jaswinder Singh Rajput wrote: > On Sat, 2009-06-27 at 12:28 -0600, Matthew Wilcox wrote: > > On Sat, Jun 27, 2009 at 11:26:28PM +0530, Jaswinder Singh Rajput wrote: > > > > On Sat, 2009-06-27 at 22:35 +0530, Jaswinder Singh Rajput wrote: > > > > > userspace cannot use scsi_command_size_tbl, COMMAND_SIZE > > > > > and scsi_device_type defined in kernel > > > > When did we start exporting include/scsi to userspace? I thought glibc > > had its own separate definitions. > > > > commit 9e4f5e29610162fd426366f3b29e3cc6e575b858 > Author: James Smart > Date: Thu Mar 26 13:33:19 2009 -0400 > > [SCSI] FC Pass Thru support That's what you get from a simplistic view. If you look at the full history, scsi.h and sg.h were exported in 2006 by the initial commit by David Woodhouse commit 8555255f0b426858d8648c6206b70eb906cf4ec7 Author: David Woodhouse Date: Sun Jun 18 12:14:01 2006 +0100 Add generic Kbuild files for 'make headers_install' They were unexported again a year later, apparently on grounds of clashing with /usr/include/scsi from glibc: commit e629a7ddc0188e1bb9e956e698a9bd00c19c9854 Author: Olaf Hering Date: Tue Oct 16 23:27:01 2007 -0700 do not export /usr/include/scsi in make headers_install So perhaps the meta question is how are we supposed to resolve this? Glibc ceded it's copy of /usr/include/linux to the kernel headers package, so it looks to be an oversight that it still retains /usr/include/scsi (there's nothing extra in there in glibc beyond what SCSI exports). James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/