Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753913AbZF1RfG (ORCPT ); Sun, 28 Jun 2009 13:35:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752651AbZF1Rey (ORCPT ); Sun, 28 Jun 2009 13:34:54 -0400 Received: from mail.open.by ([193.232.92.17]:50233 "EHLO post.open.by" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751935AbZF1Rex (ORCPT ); Sun, 28 Jun 2009 13:34:53 -0400 X-SpamTest-Envelope-From: sergey.senozhatsky@mail.by X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 8851 [Jun 28 2009] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {relay has no DNS name} X-SpamTest-Method: none X-SpamTest-Rate: 55 X-SpamTest-SPF: softfail X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0284], KAS30/Release Date: Sun, 28 Jun 2009 20:36:32 +0300 From: Sergey Senozhatsky To: Catalin Marinas Cc: Pekka Enberg , "Paul E. McKenney" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: kmemleak hexdump proposal Message-ID: <20090628173632.GA3890@localdomain.by> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6091 Lines: 167 Hello. What do you think about ability to 'watch' leaked region? (hex + ascii). (done via lib/hexdump.c) To turn on hex dump: echo "hexdump=on" > /sys/kernel/debug/kmemleak /** Or (as alternative): echo "hexdump=f6aac7f8" > /sys/kernel/debug/kmemleak where f6aac7f8 - object's pointer. **/ cat /sys/kernel/debug/kmemleak unreferenced object 0xf6aac7f8 (size 32): comm "swapper", pid 1, jiffies 4294877610 HEX dump: 70 6e 70 20 30 30 3a 30 61 00 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5 pnp 00:0a.ZZZZZZZZZZZZZZZZZZZZZ. backtrace: [] kmemleak_alloc+0x11b/0x2b0 [] kmem_cache_alloc+0x111/0x1c0 [] reserve_range+0x3e/0x1b0 [] system_pnp_probe+0x94/0x140 [] pnp_device_probe+0x84/0x100 [] driver_probe_device+0x89/0x170 [] __driver_attach+0x99/0xa0 [] bus_for_each_dev+0x58/0x90 [] driver_attach+0x24/0x40 [] bus_add_driver+0xc4/0x290 [] driver_register+0x70/0x130 [] pnp_register_driver+0x26/0x40 [] pnp_system_init+0x1b/0x2e [] do_one_initcall+0x3f/0x1a0 [] kernel_init+0x13e/0x1a6 [] kernel_thread_helper+0x7/0x10 unreferenced object 0xf63f4d18 (size 192): comm "swapper", pid 1, jiffies 4294878292 HEX dump: 3c 06 00 00 00 00 00 00 78 69 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 <.......xi...................... 25 0c 00 00 00 00 00 00 25 0c 00 00 00 00 00 00 32 05 00 00 00 00 00 00 60 54 00 00 00 00 00 00 %.......%.......2.......`T...... 0a 00 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 1f 0a 00 00 00 00 00 00 1f 0a 00 00 00 00 00 00 ................................ 28 04 00 00 00 00 00 00 48 3f 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 (.......H?...................... 19 08 00 00 00 00 00 00 19 08 00 00 00 00 00 00 1e 03 00 00 00 00 00 00 30 2a 00 00 00 00 00 00 ........................0*...... 0a 00 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 13 06 00 00 00 00 00 00 13 06 00 00 00 00 00 00 ................................ backtrace: [] kmemleak_alloc+0x11b/0x2b0 [] __kmalloc+0x16d/0x210 [] acpi_processor_register_performance+0x28e/0x468 [] acpi_cpufreq_cpu_init+0x97/0x560 [] cpufreq_add_dev+0x122/0x580 [] sysdev_driver_register+0xa7/0x140 [] cpufreq_register_driver+0x9e/0x170 [] acpi_cpufreq_init+0x8b/0xcd [] do_one_initcall+0x3f/0x1a0 [] kernel_init+0x13e/0x1a6 [] kernel_thread_helper+0x7/0x10 [] 0xffffffff To disable hex dump: echo "hexdump=off" > /sys/kernel/debug/kmemleak I guess it could safe someone's time. (May be, showed examples aren't so good. Just to demonstrate the idea.) (concept. feel free to ask for comments.) diff -u -p --- kmemleak.c 2009-06-28 20:18:59.000000000 +0300 +++ linux-2.6-sergey/mm/kmemleak.c 2009-06-28 20:21:29.000000000 +0300 @@ -160,6 +160,13 @@ struct kmemleak_object { /* flag set to not scan the object */ #define OBJECT_NO_SCAN (1 << 2) +/* number of bytes to print per line; must be 16 or 32 */ +#define HEX_ROW_SIZE 32 +/* number of bytes to print at a time (1, 2, 4, 8) */ +#define HEX_GROUP_SIZE 1 +/* include ASCII after the hex output */ +#define HEX_ASCII 1 + /* the list of all allocated objects */ static LIST_HEAD(object_list); /* the list of gray-colored objects (see color_gray comment below) */ @@ -182,6 +189,9 @@ static atomic_t kmemleak_early_log = ATO /* set if a fata kmemleak error has occurred */ static atomic_t kmemleak_error = ATOMIC_INIT(0); +/* set if HEX dump should be printed */ +static atomic_t kmemleak_hex_dump = ATOMIC_INIT(0); + /* minimum and maximum address that may be valid pointers */ static unsigned long min_addr = ULONG_MAX; static unsigned long max_addr; @@ -290,6 +300,29 @@ static int unreferenced_object(struct km jiffies_last_scan); } + +static void object_hex_dump(struct seq_file *seq, struct kmemleak_object *object) +{ + const u8 *ptr = (const u8*)object->pointer; + int len = object->size; + int i, linelen, remaining = object->size; + unsigned char linebuf[200]; + + seq_printf(seq, "HEX dump:\n"); + + for (i = 0; i < len; i += HEX_ROW_SIZE) { + linelen = min(remaining, HEX_ROW_SIZE); + remaining -= HEX_ROW_SIZE; + hex_dump_to_buffer(ptr + i, linelen, HEX_ROW_SIZE, HEX_GROUP_SIZE, + linebuf, sizeof(linebuf), HEX_ASCII); + + seq_printf(seq, "%s\n", linebuf); + } + + seq_printf(seq, "\n"); +} + + /* * Printing of the unreferenced objects information to the seq file. The * print_unreferenced function must be called with the object->lock held. @@ -301,10 +334,17 @@ static void print_unreferenced(struct se seq_printf(seq, "unreferenced object 0x%08lx (size %zu):\n", object->pointer, object->size); + seq_printf(seq, " comm \"%s\", pid %d, jiffies %lu\n", object->comm, object->pid, object->jiffies); - seq_printf(seq, " backtrace:\n"); + /* check whether hex dump should be printed*/ + if (atomic_read(&kmemleak_hex_dump)) + object_hex_dump(seq, object); + + + seq_printf(seq, " backtrace:\n"); + for (i = 0; i < object->trace_len; i++) { void *ptr = (void *)object->trace[i]; seq_printf(seq, " [<%p>] %pS\n", ptr, ptr); @@ -1269,6 +1309,12 @@ static ssize_t kmemleak_write(struct fil start_scan_thread(); else if (strncmp(buf, "scan=off", 8) == 0) stop_scan_thread(); + else if (strncmp(buf, "hexdump=on", 10) == 0) { + atomic_set(&kmemleak_hex_dump, 1); + } + else if (strncmp(buf, "hexdump=off", 11) == 0) { + atomic_set(&kmemleak_hex_dump, 0); + } else if (strncmp(buf, "scan=", 5) == 0) { unsigned long secs; int err; Sergey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/