Date: Mon, 29 Jun 2009 11:34:13 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, davidel@xmailserver.org,
       oleg@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       fbl@redhat.com, nhorman@redhat.com, htejun@gmail.com
Subject: Re: [PATCH] net: fix race in the receive/select
Message-ID: <20090629093413.GC3845@jolsa.lab.eng.brq.redhat.com>
References: <alpine.DEB.1.10.0906261018580.16400@makko.or.mcafeemobile.com> <20090626145027.GA6534@redhat.com> <alpine.DEB.1.10.0906261111230.16400@makko.or.mcafeemobile.com> <20090626.111738.141246987.davem@davemloft.net> <4A452300.5080507@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4A452300.5080507@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1208
Lines: 43

On Fri, Jun 26, 2009 at 09:35:28PM +0200, Eric Dumazet wrote:
> David Miller a ?crit :
> > From: Davide Libenzi <davidel@xmailserver.org>
> > Date: Fri, 26 Jun 2009 11:12:15 -0700 (PDT)
> > 
> >> On Fri, 26 Jun 2009, Oleg Nesterov wrote:
> >>
> >>> Perhaps we can add
> >>>
> >>> 	void sock_poll_wait(struct file *file, struct sock *sk, poll_table *pt)
> >>> 	{
> >>> 		if (pt) {
> >>> 			poll_wait(file, sk->sk_sleep, pt);
> >>> 			/*
> >>> 			 * fat comment
> >>> 			 */
> >>> 			smp_mb(); // or smp_mb__after_unlock();
> >>> 		}
> >>> 	}
> >> That'd be fine IMHO. Are DaveM and Eric OK?
> > 
> > No objections from me.
> 
> Very good :)
> 
> Jiri, please respin a patch with this idea from Oleg
> 
> (We'll have to check all calls to poll_wait() in net tree)
> 
> Thanks everybody
>

thanks a lot! :) I'll send out new patch shortly..

I'll include all the poll_wait calls change I'm kind of sure of,
and list of others I'm not, so we can discuss them.

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/