DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=F1A7+yDZAOPg1V1GSFOpNkpEIghbI5I6ge64nRK7x4vMSAgX26HH/YGllYjI7oI/cg
         3cTzlQ1yJkHZ290p21EltfjQjmT4npkg63+GlZZ4OhwnX9le6W2CPraPAv7xcWSlrl6P
         SRptSDWVAEazaAq18V1mLAkUDMw26tETFbRXo=
Date: Mon, 29 Jun 2009 13:13:36 +0200
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Ingo <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/syscall: remove redundant code
Message-ID: <20090629111334.GA6265@nowhere>
References: <4A488667.6040004@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A488667.6040004@cn.fujitsu.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1409
Lines: 42

On Mon, Jun 29, 2009 at 05:16:23PM +0800, Xiao Guangrong wrote:
> No need to call trace_wake_up() explicitly because it's called
> in trace_current_buffer_unlock_commit().
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> ---
>  kernel/trace/trace_syscalls.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 5e57964..dd1ce2c 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -168,7 +168,6 @@ void ftrace_syscall_enter(struct pt_regs *regs)
>  	syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);
>  
>  	trace_current_buffer_unlock_commit(event, 0, 0);
> -	trace_wake_up();
>  }
>  
>  void ftrace_syscall_exit(struct pt_regs *regs)
> @@ -194,7 +193,6 @@ void ftrace_syscall_exit(struct pt_regs *regs)
>  	entry->ret = syscall_get_return_value(current, regs);
>  
>  	trace_current_buffer_unlock_commit(event, 0, 0);
> -	trace_wake_up();
>  }
>  
>  static int init_syscall_tracer(struct trace_array *tr)
> -- 
> 1.6.1.2
> 

Thanks,

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/