Date: Mon, 29 Jun 2009 13:09:09 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Eric Paris <eparis@redhat.com>
cc: Al Viro <viro@zeniv.linux.org.uk>, Stephen Rothwell <sfr@canb.auug.org.au>,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       Jeremy Kerr <jk@ozlabs.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] notification tree - fsnotify assumes incorrectly
 positive parent dentry
In-Reply-To: <1246305712.754.292.camel@dhcp235-23.rdu.redhat.com>
Message-ID: <alpine.LFD.2.01.0906291305030.3605@localhost.localdomain>
References: <1246305712.754.292.camel@dhcp235-23.rdu.redhat.com>
User-Agent: Alpine 2.01 (LFD 1184 2008-12-16)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 905
Lines: 26


On Mon, 29 Jun 2009, Eric Paris wrote:
>
> Linus please consider pulling from the notification tree.  There is one
> patch in the tree which should fix an issue in which fsnotify assumed
> that dentry->d_parent->d_inode != NULL.  This turns out to be false for
> spufs and causes a panic.

Hmm. It does sound like a reasonable assumption, though. Maybe spufs 
should be fixed to have an inode for all directories?

A NULL d_inode means that something is a negative dentry, and a negative 
dentry shouldn't have children.

Added a few ppc people to the cc.

I'll pull the fix, but I really think it sounds like spufs is doing 
something wrong here.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/