Date: Mon, 29 Jun 2009 18:02:09 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeremy Kerr <jk@ozlabs.org>
cc: Eric Paris <eparis@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>,
       Stephen Rothwell <sfr@canb.auug.org.au>,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] notification tree - fsnotify assumes incorrectly
 positive parent dentry
In-Reply-To: <200906300846.30625.jk@ozlabs.org>
Message-ID: <alpine.LFD.2.01.0906291801310.3605@localhost.localdomain>
References: <1246305712.754.292.camel@dhcp235-23.rdu.redhat.com> <alpine.LFD.2.01.0906291305030.3605@localhost.localdomain> <200906300846.30625.jk@ozlabs.org>
User-Agent: Alpine 2.01 (LFD 1184 2008-12-16)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1308
Lines: 32


On Tue, 30 Jun 2009, Jeremy Kerr wrote:
> 
> > Hmm. It does sound like a reasonable assumption, though. Maybe spufs
> > should be fixed to have an inode for all directories?
> 
> We have inodes for all directories, it's just the order which we set 
> things up. When a new 'spu context' (ie, a directory with a bunch of 
> files) is created, we add the parent dentry, populate it with files 
> (positive dentries), then instantiate the parent.
> 
> There's no specific need to do it in this order, it just makes the code 
> a little simpler - we just 'stitch the parent in' once everything else 
> has completed successfully, so less stuff to do in the error path.
> 
> > A NULL d_inode means that something is a negative dentry, and a
> > negative dentry shouldn't have children.
> 
> OK. If this is a general invariant, then I'll get a change to spufs 
> going to do the setup in the right order.

Hmm. I doubt it matters a ton, but if it's easy to change it so that it 
populates the parent inode first, I think that would be a good thing. 
Thanks,

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/