Date: Tue, 30 Jun 2009 12:08:35 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
       Peter Zijlstra <peterz@infradead.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] perf stat: define CHECK_ATTRS for easy attrs
	checking
Message-ID: <20090630100835.GE6942@elte.hu>
References: <1246274348.3018.3.camel@hpdv5.satnam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1246274348.3018.3.camel@hpdv5.satnam>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1182
Lines: 34


* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> CHECK_ATTRS is useful :
>  1. for multiple attrs checking
>  2. avoid repetition of PERF_TYPE_ and PERF_COUNT_ and save space
>  3. avoids line breakage
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
>  tools/perf/builtin-stat.c |   18 ++++++++----------
>  1 files changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 3e5ea4e..6231b39 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -96,6 +96,10 @@ static u64			walltime_nsecs_noise;
>  static u64			runtime_cycles_avg;
>  static u64			runtime_cycles_noise;
>  
> +#define CHECK_ATTRS(t, c, counter)			\
> +	(attrs[counter].type == PERF_TYPE_##t &&	\
> +	 attrs[counter].config == PERF_COUNT_##c)

looks good except that the name should be something like 
MATCH_EVENT() not CHECK_ATTRS().

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/