Date: Tue, 30 Jun 2009 11:04:30 -0400
From: Andres Salomon <dilinger@collabora.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: cbou@mail.ru, dwmw2@infradead.org, linux-kernel@vger.kernel.org,
       richard@laptop.org, Andrew Morton <akpm@linux-foundation.org>,
       Paul Fox <pgf@laptop.org>, dsaxena@laptop.org
Subject: Re: [PATCH 5/5] power_supply: add a charge_type status to the api,
  and use it for olpc driver
Message-ID: <20090630110430.6c7c5cdf@mycelium.queued.net>
In-Reply-To: <20090630113135.GD13961@sirena.org.uk>
References: <20090630021730.44f86185@mycelium.queued.net>
	<20090630113135.GD13961@sirena.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1474
Lines: 39

On Tue, 30 Jun 2009 12:31:35 +0100
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> On Tue, Jun 30, 2009 at 02:17:30AM -0400, Andres Salomon wrote:
> 
> > This adds a new sysfs file called 'charge_type' which displays the
> > type of charging (n/a, trickle charge, slow charge, or fast
> > charging).  This allows things like battery diagnostics to
> > determine what the battery/EC is doing without resorting to
> > changing the 'status' sysfs output.
> 
> > Signed-off-by: Andres Salomon <dilinger@collabora.co.uk>
> 
> This looks good to me.  Could you please keep me on the CC for any
> future revisions of this patch, I can make use of this in the WM8350
> driver.

Sure.


> 
> > +	static char *charge_type[] = {
> > +		"N/A", "Trickle", "Slow", "Fast"
> > +	};
> 
> I'd be tempted to make "N/A" be "Unknown" to match the style of the
> rest of the attributes.  I'm also not sure that we need a slow type,
> but equally it shouldn't do any harm.


It's known though, right? :)   It could just as easily be "None",
"Unknown", etc, but I'm not particularly picky.  As far as the slow
type, I don't see the need either, but I assumed Anton was aware of
devices that differentiated between slow and trickle charging.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/