DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=exjQ0QqzwLRh+3XnvTQPSCAsnngI8EQuqxnE+i7ZU2B2eErhFDufufZ+oCoCdTAmP9qFuaPG/Jv2RVcRGDQhfzmspFp6JRx4R1CFsNA1za9wxZVFlV8Mi85n19FpkvZQ;
Date: Tue, 30 Jun 2009 14:00:43 -0700
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Gary Hade <garyhade@us.ibm.com>
Cc: Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@elte.hu>,
       Matthew Wilcox <matthew@wil.cx>, "H. Peter Anvin" <hpa@zytor.com>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Thomas Gleixner <tglx@linutronix.de>,
       Suresh Siddha <suresh.b.siddha@intel.com>,
       Andrew Morton <akpm@linux-foundation.org>, linux-pci@vger.kernel.org,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] x86/pci: fix boundary checking when using root CRS
Message-ID: <20090630140043.1c9caa7a@jbarnes-g45>
In-Reply-To: <20090630180449.GA7183@us.ibm.com>
References: <20090624122433.GA24781@elte.hu>
	<20090624145119.GA12664@elte.hu>
	<4A429EBB.5010209@kernel.org>
	<4A42DA6F.2030305@kernel.org>
	<20090629181603.261ccd03@jbarnes-g45>
	<20090630180449.GA7183@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1288
Lines: 38

On Tue, 30 Jun 2009 11:04:49 -0700
Gary Hade <garyhade@us.ibm.com> wrote:

> On Mon, Jun 29, 2009 at 06:16:03PM -0700, Jesse Barnes wrote:
> > On Wed, 24 Jun 2009 19:01:19 -0700
> > Yinghai Lu <yinghai@kernel.org> wrote:
> > 
> > > 
> > > don't touch info->res_num if we are out of space
> > > 
> > > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> > 
> > Gary, any comments on these?
> 
> Jesse,
> "[PATCH 1/3] x86/pci: fix boundary checking when using root CRS"
> which convinced that my code was incorrect and
> "[PATCH 2/3] x86/pci: get root CRS before scan childs -v3"
> look good to me from both code review and functional [1] standpoints.
>   Acked-by: <garyhade@us.ibm.com>
>   Tested-by: <garyhade@us.ibm.com>
> 
> [1] Successful boot of patched 2.6.31-rc1 with pci=use_crs
>     followed by successful hot-add and hot-remove of PCI-X
>     and PCIe cards on an IBM x3850.
> 
> Thanks Yinghai.

Thanks guys, I've applied these to my for-linus branch for a pull later
this week.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/