Date: Tue, 30 Jun 2009 23:54:37 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Howells <dhowells@redhat.com>, torvalds@osdl.org,
       akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FRV: Wire up new syscalls
Message-ID: <20090630215437.GB22851@elte.hu>
References: <20090630212454.19294.75622.stgit@warthog.procyon.org.uk> <20090630213406.GB17492@elte.hu> <200906302341.58582.arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200906302341.58582.arnd@arndb.de>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1258
Lines: 31


* Arnd Bergmann <arnd@arndb.de> wrote:

> On Tuesday 30 June 2009, Ingo Molnar wrote:
> > * David Howells <dhowells@redhat.com> wrote:
> > 
> > > Wire up new syscalls rt_tgsigqueueinfo and perf_counter_open.
> > 
> > > +     .long sys_perf_counter_open
> > 
> > Hm, i suspect this should be sys_ni because FRV does not set 
> > HAVE_PERF_COUNTERS so perfcounters cannot be enabled. (Or do you 
> > have patches in the pipeline that enable perfcounters for FRV?)
> 
> It doesn't matter because of the cond_syscall() in 
> kernel/sys_ni.c. Right now, scripts/checksyscalls.sh causes a 
> warning on each architecture that does not assign a system call 
> number for sys_perf_counter_open, so they might as well make it 
> point to sys_ni though cond_syscall().

It would make sense to wire it up for real as it's really easy: just 
set HAVE_PERF_COUNTERS in arch/frv/Kconfig, add an empty 
arch/frv/include/asm/perf_counter.h file. (Optional: double check 
that tools/perf/ builds and works fine on FRV ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/