Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759614AbZF3W4e (ORCPT ); Tue, 30 Jun 2009 18:56:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759411AbZF3W4G (ORCPT ); Tue, 30 Jun 2009 18:56:06 -0400 Received: from terminus.zytor.com ([198.137.202.10]:58848 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759322AbZF3W4D (ORCPT ); Tue, 30 Jun 2009 18:56:03 -0400 Message-ID: <4A4A97BB.9040805@zytor.com> Date: Tue, 30 Jun 2009 15:54:51 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Yinghai Lu CC: Linus Torvalds , Ingo Molnar , Mikael Pettersson , Matthew Wilcox , Grant Grundler , Linux Kernel Mailing List , linux-pci@vger.kernel.org Subject: Re: [BUG 2.6.31-rc1] HIGHMEM64G causes hang in PCI init on 32-bit x86 References: <200906261559.n5QFxJH8027336@pilspetsen.it.uu.se> <19013.29264.623540.275538@pilspetsen.it.uu.se> <4A45A5C1.5080701@zytor.com> <19013.59956.144640.331854@pilspetsen.it.uu.se> <20090629022911.GC20297@lackof.org> <4A484A8A.9020704@zytor.com> <19016.41349.636663.515540@pilspetsen.it.uu.se> <20090629112155.GJ5480@parisc-linux.org> <19016.44061.600652.676183@pilspetsen.it.uu.se> <4A490804.3040609@zytor.com> <4A494478.7020304@kernel.org> <4A494E3C.70304@kernel.org> <4A495C0D.2020807@zytor.com> <4A4966EF.6010809@kernel.org> <4A496D4B.3040608@kernel.org> <19017.53428.834539.389495@pilspetsen.it.uu.se> <4A4A25B1.5010102@zytor.com> <4A4A6888.30001@kernel.org> <4A4A6B1C.7030405@zytor.com> <4A4A701F.3050700@kernel.org> <4A4A81C9.9070008@zytor.com> <4A4A88A2.7010509@kernel.org> <4A4A921F.7080100@kernel.org> <4A4A96F7.4010302@kernel.org> In-Reply-To: <4A4A96F7.4010302@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 679 Lines: 28 Yinghai Lu wrote: >>> >>> Not very well tested, but it _looks_ correct, and uses Peter's trick, and >>> willlet the compiler notice that >>> >>> round_up(x,y)-1 >>> >>> is the same thing as >>> >>> x | (y-1) >>> >>> which it _could_ have perhaps figured out before, but now it's way more >>> obvious. >> how about x = 0, y = 0x100? >> > > also x=0x100000, and y=0x100? > Yes, it doesn't work when x is already aligned. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/