Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759465AbZGAA3o (ORCPT ); Tue, 30 Jun 2009 20:29:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759351AbZGAA3f (ORCPT ); Tue, 30 Jun 2009 20:29:35 -0400 Received: from mail.parknet.ad.jp ([210.171.162.6]:46935 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759385AbZGAA3d (ORCPT ); Tue, 30 Jun 2009 20:29:33 -0400 From: OGAWA Hirofumi To: Marton Balint Cc: linux-kernel@vger.kernel.org Subject: Re: vfat creates multiple files with the same filename References: <87tz1ylaq8.fsf@devron.myhome.or.jp> Date: Wed, 01 Jul 2009 09:29:34 +0900 In-Reply-To: (Marton Balint's message of "Wed, 1 Jul 2009 02:02:53 +0200 (CEST)") Message-ID: <87y6r9dz4h.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.10/RELEASE, bases: 24052007 #308098, status: clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 32 Marton Balint writes: > On Tue, 30 Jun 2009, OGAWA Hirofumi wrote: >> Marton Balint writes: >> >> > I don't know if removing the invalid characters silently instead of >> > returning EINVAL is a good practice, but allowing two files with identical >> > filenames is definitely wrong. >> >> The utf8 function seems didn't return the error for invalid char. >> >> > Could someone please have a look at the problem? Unfortunately I am not >> > qualified enough to track it down... >> > >> > I've run the testcase on both 2.6.30 and 2.6.31-rc1 kernels, but this bug >> > is probably not very new, since I remember having it also in 2.6.27. >> >> This is quick hack though, this should return -EINVAL for invalid char >> like nls. Can you try this? > > It works for me, filenames with invalid utf-8 characters are now rejected, > so I no longer can create multiple files with the same name. Thanks for > the fix. Thanks for testing. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/