Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765365AbZGABDJ (ORCPT ); Tue, 30 Jun 2009 21:03:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760640AbZGAAfF (ORCPT ); Tue, 30 Jun 2009 20:35:05 -0400 Received: from kroah.org ([198.145.64.141]:60451 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760246AbZGAAfC (ORCPT ); Tue, 30 Jun 2009 20:35:02 -0400 X-Mailbox-Line: From gregkh@mini.kroah.org Tue Jun 30 17:24:31 2009 Message-Id: <20090701002431.551098249@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Tue, 30 Jun 2009 17:23:48 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Peter Zijlstra , Ingo Molnar Subject: [patch 059/108] lockdep: Select frame pointers on x86 References: <20090701002249.937782934@mini.kroah.org> Content-Disposition: inline; filename=lockdep-select-frame-pointers-on-x86.patch In-Reply-To: <20090701002838.GA7100@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 30 2.6.30-stable review patch. If anyone has any objections, please let us know. ------------------ From: Peter Zijlstra commit 00540e5d54be972a94a3b2ce6da8621bebe731a2 upstream. x86 stack traces are a piece of crap without frame pointers, and its not like the 'performance gain' of not having stack pointers matters when you selected lockdep. Reported-by: Andrew Morton LKML-Reference: Signed-off-by: Peter Zijlstra Signed-off-by: Ingo Molnar Signed-off-by: Greg Kroah-Hartman --- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -440,7 +440,7 @@ config LOCKDEP bool depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT select STACKTRACE - select FRAME_POINTER if !X86 && !MIPS && !PPC && !ARM_UNWIND && !S390 + select FRAME_POINTER if !MIPS && !PPC && !ARM_UNWIND && !S390 select KALLSYMS select KALLSYMS_ALL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/