Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765176AbZGABI4 (ORCPT ); Tue, 30 Jun 2009 21:08:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759613AbZGAAfZ (ORCPT ); Tue, 30 Jun 2009 20:35:25 -0400 Received: from kroah.org ([198.145.64.141]:60566 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761518AbZGAAfS (ORCPT ); Tue, 30 Jun 2009 20:35:18 -0400 X-Mailbox-Line: From gregkh@mini.kroah.org Tue Jun 30 17:24:37 2009 Message-Id: <20090701002437.050628914@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Tue, 30 Jun 2009 17:24:05 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Dan Williams , NeilBrown Subject: [patch 076/108] md/raid5: add missing call to schedule() after prepare_to_wait() References: <20090701002249.937782934@mini.kroah.org> Content-Disposition: inline; filename=md-raid5-add-missing-call-to-schedule-after-prepare_to_wait.patch In-Reply-To: <20090701002838.GA7100@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 31 2.6.30-stable review patch. If anyone has any objections, please let us know. ------------------ From: Dan Williams commit 7a3ab908948b6296ee7e81d42f7c176361c51975 upstream. In the unlikely event that reshape progresses past the current request while it is waiting for a stripe we need to schedule() before retrying for 2 reasons: 1/ Prevent list corruption from duplicated list_add() calls without intervening list_del(). 2/ Give the reshape code a chance to make some progress to resolve the conflict. Signed-off-by: Dan Williams Signed-off-by: NeilBrown Signed-off-by: Greg Kroah-Hartman --- drivers/md/raid5.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -3696,6 +3696,7 @@ static int make_request(struct request_q spin_unlock_irq(&conf->device_lock); if (must_retry) { release_stripe(sh); + schedule(); goto retry; } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/