Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbZGAGhp (ORCPT ); Wed, 1 Jul 2009 02:37:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752120AbZGAGhh (ORCPT ); Wed, 1 Jul 2009 02:37:37 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:25891 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbZGAGhg (ORCPT ); Wed, 1 Jul 2009 02:37:36 -0400 Date: Wed, 1 Jul 2009 08:37:37 +0200 From: Erik Ekman To: linux-kernel@vger.kernel.org Subject: [PATCH -tip][RFC] serial8250: update to dev_pm_ops Message-Id: <20090701083737.41f28c7d.erik@kryo.se> X-Mailer: Sylpheed 2.5.0 (GTK+ 2.14.7; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2072 Lines: 73 serial8250: update to dev_pm_ops >From dmesg: Platform driver 'serial8250' needs updating - please use dev_pm_ops Is this how it should be done? I have not tested it, but it compiles fine. Should I send in similar patches for other drivers that also give this message? Signed-off-by: Erik Ekman --- diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index fb867a9..dcbc6da 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c @@ -2982,42 +2982,46 @@ static int __devexit serial8250_remove(struct platform_device *dev) return 0; } -static int serial8250_suspend(struct platform_device *dev, pm_message_t state) +static int serial8250_suspend(struct device *dev) { int i; for (i = 0; i < UART_NR; i++) { struct uart_8250_port *up = &serial8250_ports[i]; - if (up->port.type != PORT_UNKNOWN && up->port.dev == &dev->dev) + if (up->port.type != PORT_UNKNOWN && up->port.dev == dev) uart_suspend_port(&serial8250_reg, &up->port); } return 0; } -static int serial8250_resume(struct platform_device *dev) +static int serial8250_resume(struct device *dev) { int i; for (i = 0; i < UART_NR; i++) { struct uart_8250_port *up = &serial8250_ports[i]; - if (up->port.type != PORT_UNKNOWN && up->port.dev == &dev->dev) + if (up->port.type != PORT_UNKNOWN && up->port.dev == dev) serial8250_resume_port(i); } return 0; } +static struct dev_pm_ops serial8250_pm_ops = { + .suspend = serial8250_suspend, + .resume = serial8250_resume, +}; + static struct platform_driver serial8250_isa_driver = { .probe = serial8250_probe, .remove = __devexit_p(serial8250_remove), - .suspend = serial8250_suspend, - .resume = serial8250_resume, .driver = { .name = "serial8250", .owner = THIS_MODULE, + .pm = &serial8250_pm_ops, }, }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/