Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752865AbZGAOKW (ORCPT ); Wed, 1 Jul 2009 10:10:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751766AbZGAOKM (ORCPT ); Wed, 1 Jul 2009 10:10:12 -0400 Received: from fg-out-1718.google.com ([72.14.220.156]:50052 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbZGAOKL (ORCPT ); Wed, 1 Jul 2009 10:10:11 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version:content-type; b=XxlojeBkjkXj5CaLYt1drO/UKRsb/l6PEv/WdWE7ZrudFpM3RxjnA2nH2LiLINX4Zv wUiQuGSJhMVHsS1TD4qVO6jwhbdJN+GbvRtUqpWHbkwWVdXdZqA9TnebZQU35mwl+EYQ fVskiAnW+GJE6I7iZgv2r5Mwn1NwD9VcxKe6E= Date: Wed, 01 Jul 2009 16:10:11 +0200 Message-ID: <87d48kh4u4.wl%vmayatsk@redhat.com> From: Vitaly Mayatskikh To: Oleg Nesterov Cc: Vitaly Mayatskikh , Roland McGrath , linux-kernel@vger.kernel.org Subject: Re: wait_task_zombie plus WNOWAIT question In-Reply-To: <20090701135544.GA24374@redhat.com> References: <87eit0h66p.wl%vmayatsk@redhat.com> <20090701135544.GA24374@redhat.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/23.0 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 27 At Wed, 1 Jul 2009 15:55:44 +0200, Oleg Nesterov wrote: > > On 07/01, Vitaly Mayatskikh wrote: > > > > I'm working on (sigh) next version of wait_task_* cleanups and stuck > > in wait_task_zombie. I'm trying to move put_user(stat, wo->wo_stat) > > code from all wait_task_* functions to common place, but > > wait_task_zombie does not fill wo_stat if WNOWAIT flag is set > > Only waitid() can use WNOWAIT, and in this case ->wo_stat == NULL. > > > and does > > it w/o that flag. Is it done so by design, or I can make > > user-visible change and add put_user in WNOWAIT path? > > Just check do not do put_user(->wo_stat) if it is NULL in do_wait > pathes. Got it! Thanks, Oleg! -- wbr, Vitaly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/