Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754146AbZGARYR (ORCPT ); Wed, 1 Jul 2009 13:24:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753794AbZGARYE (ORCPT ); Wed, 1 Jul 2009 13:24:04 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35494 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753745AbZGARYD (ORCPT ); Wed, 1 Jul 2009 13:24:03 -0400 Message-ID: <4A4B9BA1.6040109@redhat.com> Date: Wed, 01 Jul 2009 13:23:45 -0400 From: Rik van Riel Organization: Red Hat, Inc User-Agent: Thunderbird 2.0.0.17 (X11/20080915) MIME-Version: 1.0 To: Christoph Lameter CC: David Howells , KOSAKI Motohiro , Minchan Kim , Johannes Weiner , Andrew Morton , LKML , "peterz@infradead.org" , "tytso@mit.edu" , "linux-mm@kvack.org" , "elladan@eskimo.com" , "npiggin@suse.de" , "Barnes, Jesse" Subject: Re: [PATCH v2] Show kernel stack usage to /proc/meminfo and OOM log References: <20090701103622.85CD.A69D9226@jp.fujitsu.com> <20090701082531.85C2.A69D9226@jp.fujitsu.com> <10604.1246459458@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 20 Christoph Lameter wrote: > On Wed, 1 Jul 2009, David Howells wrote: > >> KOSAKI Motohiro wrote: >> >>> + int pages = THREAD_SIZE / PAGE_SIZE; >> Bad assumption. On FRV, for example, THREAD_SIZE is 8K and PAGE_SIZE is 16K. > > Guess that means we need arch specific accounting for this counter. Or we count the number of stacks internally and only convert to pages whenever we display the value. -- All rights reversed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/