Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755806AbZGARdm (ORCPT ); Wed, 1 Jul 2009 13:33:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754122AbZGARdd (ORCPT ); Wed, 1 Jul 2009 13:33:33 -0400 Received: from mx2.redhat.com ([66.187.237.31]:36317 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753415AbZGARdd (ORCPT ); Wed, 1 Jul 2009 13:33:33 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20090701144913.GA28172@elte.hu> <20090701164700.29780.15103.stgit@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, mingo@elte.hu, akpm@linux-foundation.org, paulus@samba.org, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] FRV: Implement atomic64_t Date: Wed, 01 Jul 2009 18:33:24 +0100 Message-ID: <20552.1246469604@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 510 Lines: 15 Linus Torvalds wrote: > > +#define atomic64_read(v) ((v)->counter) > > +#define atomic64_set(v, i) (((v)->counter) = (i)) > > These seem to be buggy. Good point. I should be doing inline asm with LDD and STD instructions. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/