Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755736AbZGASrS (ORCPT ); Wed, 1 Jul 2009 14:47:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752456AbZGASrJ (ORCPT ); Wed, 1 Jul 2009 14:47:09 -0400 Received: from mail-fx0-f218.google.com ([209.85.220.218]:46873 "EHLO mail-fx0-f218.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbZGASrI convert rfc822-to-8bit (ORCPT ); Wed, 1 Jul 2009 14:47:08 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Kay Sievers Date: Wed, 1 Jul 2009 20:46:55 +0200 Message-ID: Subject: Re: Problem with /proc/iomem on ARM To: H Hartley Sweeten Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1182 Lines: 30 On Wed, Jul 1, 2009 at 20:24, H Hartley Sweeten wrote: > On Wednesday, July 01, 2009 11:13 AM, Kay Sievers wrote: >>> The serial ports on my system are amba bus devices. >>> >>>> After all, it seems like this should be fixed in arm somewhere, not to >>>> copy and store internal driver core pointers, but use the device >>>> itself to retrieve the values. >>> >>> Maybe the problem is in drivers/amba/bus.c? amba_device_register() does: >>> >>>        dev->res.name = dev_name(&dev->dev); >> >> Looks like. If you get the name directly from dev->init_name. Does that work? >> > > The following patch does fix /proc/iomem for the amba uarts on my system. > Is this the correct approach to fixing the issue? Looks fine to work around the issue that statically allocated struct devices can cause. The proper fix would be to convert them to dynamic objects and get rid of .init_name entirely. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/