Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003AbZGBFoD (ORCPT ); Thu, 2 Jul 2009 01:44:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750822AbZGBFny (ORCPT ); Thu, 2 Jul 2009 01:43:54 -0400 Received: from 136-022.dsl.LABridge.com ([206.117.136.22]:2823 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbZGBFnx (ORCPT ); Thu, 2 Jul 2009 01:43:53 -0400 Subject: Re: printk regression? From: Joe Perches To: Linus Torvalds Cc: Yinghai Lu , Ingo Molnar , "linux-kernel@vger.kernel.org" In-Reply-To: References: <4A4C3410.8080704@kernel.org> Content-Type: text/plain Date: Wed, 01 Jul 2009 22:42:36 -0700 Message-Id: <1246513356.28915.62.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 25 On Wed, 2009-07-01 at 21:23 -0700, Linus Torvalds wrote: > > On Wed, 1 Jul 2009, Yinghai Lu wrote: > > > > [ 75.690022] <7>printing local APIC contents on CPU#0/0: > > Yes. This is because the io_apic code should be fixed. > > It does: > > printk("\n" KERN_DEBUG "printing local APIC > > and that "\n" at the beginning should just be deleted. The log-level > should be at the beginning of the printk, not in the middle. There's at least 72 of them: $ grep -Pr --include=*.[ch] "\bprintk.*\\\n.*KERN_" * -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/