Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755604AbZGBJar (ORCPT ); Thu, 2 Jul 2009 05:30:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752064AbZGBJah (ORCPT ); Thu, 2 Jul 2009 05:30:37 -0400 Received: from mail-bw0-f225.google.com ([209.85.218.225]:64254 "EHLO mail-bw0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbZGBJag (ORCPT ); Thu, 2 Jul 2009 05:30:36 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-mutt-references :x-mutt-fcc:user-agent; b=lk9xwT7IgDrvewPa6TMZPq5tPmdEkftxS6+T60fOAe9ne+oktZiVnozV+yREGhHYNr UecrdZnsHYM5raQWv7UZAVsIi+8NwHpNSSVs2ARV/uslHhiONzkleDqmwhFXEh5VeIH9 d+nONvG4kao4MNi3QXtXAYVa9WRtJRAbXXiBc= Date: Thu, 2 Jul 2009 09:30:31 +0000 From: Jarek Poplawski To: Andres Freund Cc: LKML , netdev@vger.kernel.org, Stephen Hemminger , Patrick McHardy Subject: Re: Soft-Lockup/Race in networking in 2.6.31-rc1+195 (possibly caused by netem) Message-ID: <20090702093031.GC4954@ff.dom.local> References: <4A4A9DD6.8060800@anarazel.de> <4A4BAD5F.7050908@gmail.com> <4A4BD384.3090407@anarazel.de> <4A4C0144.5070203@anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A4C0144.5070203@anarazel.de> X-Mutt-References: <4A4C0144.5070203@anarazel.de> X-Mutt-Fcc: =outbox User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 35 On Thu, Jul 02, 2009 at 02:37:24AM +0200, Andres Freund wrote: ... > So I tried - and I did not catch any lockdep output before the crash. > Unfortunately I do not have another machine on the same local network to > catch any messages after the crash... So I could be missing some warning > (I did synchronous logging though). > Will check with netconsole tomorrow. Could you try if this patch changes anything? Thanks, Jarek P. --- net/sched/sch_netem.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 2b88295..6001ad9 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -176,8 +176,6 @@ static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch) return NET_XMIT_SUCCESS | __NET_XMIT_BYPASS; } - skb_orphan(skb); - /* * If we need to duplicate packet, then re-insert at top of the * qdisc tree, since parent queuer expects that only one -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/