Message-ID: <4A4C8021.8070509@redhat.com>
Date: Thu, 02 Jul 2009 17:38:41 +0800
From: Amerigo Wang <amwang@redhat.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090319)
MIME-Version: 1.0
To: Roland McGrath <roland@redhat.com>
CC: linux-kernel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>,
       Serge Hallyn <serue@us.ibm.com>, David Howells <dhowells@redhat.com>,
       James Morris <jmorris@namei.org>, linux-fsdevel@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Patch 3/3] elf: use a macro instead of a raw number
References: <20090701050840.6188.84560.sendpatchset@localhost.localdomain>	<20090701050900.6188.41697.sendpatchset@localhost.localdomain> <20090701073810.A80FC21D57@magilla.sf.frob.com>
In-Reply-To: <20090701073810.A80FC21D57@magilla.sf.frob.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 795
Lines: 25

Roland McGrath wrote:
>> Use TASK_COMM_LEN instead of the raw number 16.
>>     
>
> This is probably a bad idea.  elf_prpsinfo layout is a userland ABI.
> AFAIK there is no reason TASK_COMM_LEN could not be enlarged in the kernel.
>   

Thanks for your reply.

But in the kernel code, pr_fname is copied from ->comm, they should
be equal, shouldn't they?

Hmm, yes, I agree that 16 is too small for ELF core dump, the longer
names get truncated and gdb will complain about this...

I can cook a patch to increase this length if you agree.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/