Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754116AbZGBKuj (ORCPT ); Thu, 2 Jul 2009 06:50:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752260AbZGBKuc (ORCPT ); Thu, 2 Jul 2009 06:50:32 -0400 Received: from h5.dl5rb.org.uk ([81.2.74.5]:51509 "EHLO h5.dl5rb.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbZGBKub (ORCPT ); Thu, 2 Jul 2009 06:50:31 -0400 Date: Thu, 2 Jul 2009 11:50:24 +0100 From: Ralf Baechle To: Wu Zhangjin Cc: LKML , linux-mips@linux-mips.org, Pavel Machek Subject: Re: [BUG] MIPS: Hibernation in the latest linux-mips:master branch not work Message-ID: <20090702105024.GD14804@linux-mips.org> References: <1246372868.19049.17.camel@falcon> <20090630144540.GA18212@linux-mips.org> <1246374687.20482.10.camel@falcon> <20090701180715.GA23121@linux-mips.org> <1246496647.9660.46.camel@falcon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246496647.9660.46.camel@falcon> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1453 Lines: 42 On Thu, Jul 02, 2009 at 09:04:07AM +0800, Wu Zhangjin wrote: > > > hi, ralf, in the latest master branch of linux-mips git repo, seems > > > there is a need to select the SYS_SUPPORTS_HOTPLUG_CPU option in every > > > uni-processor board, otherwise, the suspend/hibernation can not be used, > > > because you have set: > > > > > > config ARCH_HIBERNATION_POSSIBLE > > > def_bool y > > > depends on SYS_SUPPORTS_HOTPLUG_CPU > > > > > > config ARCH_SUSPEND_POSSIBLE > > > def_bool y > > > depends on SYS_SUPPORTS_HOTPLUG_CPU > > > > > > so, the board-specific patch must be pushed by the maintainers of > > > boards. and if the board support SMP, they must implement the > > > mips-specific hotplug support, is this right? I have selected > > > SYS_SUPPORTS_HOTPLUG_CPU in LEMOTE_FULONG and will push a relative patch > > > later. > > > > I think below patch should take care of this problem. It simply assumes > > that all uniprocessor systems support suspend and hibernate. That's an > > assumption that I'm not to unhappy with though it may force us to fix a > > few systems. > > > > This patch is better. > > Thanks! > Wu Zhangjin Thanks, patch applied. You're welcome! Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/