Subject: Re: printk regression?
From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@elte.hu>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <alpine.LFD.2.01.0907021020200.4830@localhost.localdomain>
References: <4A4C3410.8080704@kernel.org>
	 <alpine.LFD.2.01.0907012119370.3380@localhost.localdomain>
	 <1246513356.28915.62.camel@Joe-Laptop.home>
	 <alpine.LFD.2.01.0907021020200.4830@localhost.localdomain>
Content-Type: text/plain
Date: Thu, 02 Jul 2009 10:38:40 -0700
Message-Id: <1246556320.28915.92.camel@Joe-Laptop.home>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1079
Lines: 31

On Thu, 2009-07-02 at 10:27 -0700, Linus Torvalds wrote:
> Of course, some cases are just crazy. Here's one:
> 
> 	arch/m68knommu/kernel/traps.c:          printk(KERN_CONT "\n" KERN_EMERG " [%08lx] ", addr);
> 
> and I have no clue about why it would have KERN_CONT there.

Generally, it's because hardware is being scanned in little
bits and pieces with partial line printk's being used to
document things "as it happens".

If something odd happens, the "in-progress" printk's are
terminated and another "whoa nellie" printk is done.

There's a bunch of that in drivers/net.

>  That makes 
> little sense. Again, with the new printk logic, it really should be just
> 
> 	printk(KERN_EMERG " [%08lx] ", addr);
> 
> and nothing odd.

Maybe, but your printk change does require that all of
the kernel sources be updated as necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/