Content-Class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: [lm-sensors] [PATCH] adxl345 accelerometer hwmon driver
Date: Thu, 2 Jul 2009 19:12:26 +0100
Message-ID: <8A42379416420646B9BFAC9682273B6D0C2497DC@limkexm3.ad.analog.com>
In-Reply-To: <4A4CF587.1030202@gmail.com>
Thread-Topic: [lm-sensors] [PATCH] adxl345 accelerometer hwmon driver
Thread-Index: Acn7PwVYziD9+qw8TACFyem06RQ4sAAAOHYQ
References: <68FBE0F3CE97264395875AC1C468F22C152BE8@mail03.cyberswitching.local> 	<4A4CF07B.3090600@cam.ac.uk> <8bd0f97a0907021043l30a34e6dh581ea5e96130d7eb@mail.gmail.com> <4A4CF587.1030202@gmail.com>
From: "Hennerich, Michael" <Michael.Hennerich@analog.com>
To: "Jonathan Cameron" <Jonathan.Cameron@gmail.com>,
       "Mike Frysinger" <vapier.adi@gmail.com>
CC: "Jonathan Cameron" <jic23@cam.ac.uk>,
       "Chris Verges" <chrisv@cyberswitching.com>,
       <linux-kernel@vger.kernel.org>, <lm-sensors@lm-sensors.org>,
       "Robin Getz" <rgetz@blackfin.uclinux.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2435
Lines: 80


>From: J.I. Cameron [mailto:jic23@hermes.cam.ac.uk] On Behalf Of
Jonathan Cameron
>Mike Frysinger wrote:
>> On Thu, Jul 2, 2009 at 13:38, Jonathan Cameron wrote:
>>
>>> One interesting thing I just came across whilst searching lkml for
>>> your post to reply to, was that Mike Frysinger submited a patch
>>> adding some board support for an adx34x driver to bf548-ezkit.
>>> I've not seen any sign of this anywhere else as yet (it hasn't
>>> hit the input list which would be the obvious place) I've copied in
>>> both people who signed off.  Michael or Mike able to give us more
info?
>>>
>>
>> that's because we're still in the process of making sure it is
stable.
>>  I2C is a pita to work with.
>>
>http://git.kernel.org/?p=linux/kernel/git/vapier/blackfin.git;a=commitd
iff;h=43d4cabbdeb5c24f84b159c5
>dc369c1a60844a48
>>
>> the advantage here is that we have been testing our driver with
actual
>> hardware ...
>>
>Cheat ;)
>
>Looks like a nice driver, see what you mean about the i2c fun and games
>you are having
>though.
>I'm particularly interested in your use of the fifo:
>
>I've only had a quick look, but assuming I read it right, you are using
>the fifo
>with a watermark of 0 then spitting out 3 separate events for every
>element in it.
>Basically a data ready response unless you fail to read in time. Seems
>like a sensible
>approach with this particular chip in input type applications.

We fully use the FIFO - the link Mike sent around was the initial
checkin.
After that I fixes some bugs and added functionality.
BTW I also implemented the Watermark feature.

http://docs.blackfin.uclinux.org/doku.php?id=linux-kernel:drivers:adxl34
x


>
>Does this work well even at the higher rates?  Seems a fair bit of
>overhead but I guess
>if everything is quick enough it doesn't really matter. Does this act
as
>a clean means
>of ensuring you get a consistent set of values?

It works pretty well - the driver supports both SPI and I2C interface.
With SPI it's no problem to even use the 3200HZ sample rate.

See the comments in our documentation page.
400kHz I2C clock is the limiting factor when using the I2C interface.


Best regards,
Michael

>
>Thanks,
>
>Jonathan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/