Subject: Re: [RFC patch] disable the assumption of apic_is_clustered_box
 for cores 	>= 6
From: Suresh Siddha <suresh.b.siddha@intel.com>
Reply-To: suresh.b.siddha@intel.com
To: Luming Yu <luming.yu@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
       "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
In-Reply-To: <3877989d0906291953n599b7047x5fdf6033114e0eed@mail.gmail.com>
References: <3877989d0906291953n599b7047x5fdf6033114e0eed@mail.gmail.com>
Content-Type: text/plain
Organization: Intel Corp
Date: Thu, 02 Jul 2009 12:04:42 -0700
Message-Id: <1246561482.27006.10694.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1165
Lines: 31

On Mon, 2009-06-29 at 19:53 -0700, Luming Yu wrote:
> Hello,
> 
> We have to disable the assumption of apic_is_clustered_box that assumes high
> 4bits of 8 bit APIC ID was cluster id, which is just the function's guess.
> On a normal 4-socket system with >6cores Processor and HT enabled, we hit the
> limitation of the guess and failed. Have to disable the guess on any
> cores > 6 system.
> 
> Without this patch, we can't use good TSC on any SMP system with 48+ logical CPU

This patch doesn't seem to be the right fix. BTW, it appears that
Yinghai's patch in mainline appear to address this issue already. Did
you check if the mainline still has the issue that you are trying to fix
here?

commit e0e42142bab96404de535cceb85d6533d5ad7942
Author: Yinghai Lu <yinghai@kernel.org>
Date:   Sun Apr 26 23:39:38 2009 -0700

    x86: Use dmi check in apic_is_clustered() on 64-bit to mark the TSC
unstable

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/