Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756093AbZGBVpU (ORCPT ); Thu, 2 Jul 2009 17:45:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754190AbZGBVpI (ORCPT ); Thu, 2 Jul 2009 17:45:08 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:60521 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbZGBVpH (ORCPT ); Thu, 2 Jul 2009 17:45:07 -0400 Date: Thu, 2 Jul 2009 23:45:03 +0200 From: Pavel Machek To: Wu Zhangjin Cc: LKML , linux-mips@linux-mips.org, Ralf Baechle , Wu Zhangjin Subject: Re: [PATCH] [MIPS] Hibernation: only save pages in system ram Message-ID: <20090702214503.GC1485@ucw.cz> References: <1246373570-21090-1-git-send-email-wuzhangjin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246373570-21090-1-git-send-email-wuzhangjin@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 32 > arch/mips/include/asm/page.h: > > ... > #ifdef CONFIG_FLATMEM > > #define pfn_valid(pfn) ((pfn) >= ARCH_PFN_OFFSET && (pfn) < max_mapnr) > > #elif defined(CONFIG_SPARSEMEM) > > /* pfn_valid is defined in linux/mmzone.h */ > ... > > we can rewrite pfn_valid(pfn) to fix this problem, but I really do not > want to touch such a widely-used macro, so, I used another solution: Well, fixing pfn_valid() is the right way to go. It makes mips behave like other architectures. Please do that. > Signed-off-by: Wu Zhangjin NAK. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/