Date: Fri, 3 Jul 2009 01:11:52 +0200 (CEST)
From: Jiri Kosina <jkosina@suse.cz>
To: Horst Schirmeier <horst@schirmeier.com>
Cc: rdunlap@xenotime.net, linux-doc@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] doc: missing value 2 for randomize-va-space
In-Reply-To: <20090702152338.GU26384@quickstop.soohrt.org>
Message-ID: <alpine.LNX.2.00.0907030109191.4994@wotan.suse.de>
References: <20090702152338.GU26384@quickstop.soohrt.org>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1567
Lines: 42

On Thu, 2 Jul 2009, Horst Schirmeier wrote:

> The documentation for /proc/sys/kernel/* does not mention the possible
> value 2 for randomize-va-space (but already mentions what it does).

Hmm, while you are at it ...

>  Documentation/sysctl/kernel.txt |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/sysctl/kernel.txt b/Documentation/sysctl/kernel.txt
> index 322a00b..b2af4ef 100644
> --- a/Documentation/sysctl/kernel.txt
> +++ b/Documentation/sysctl/kernel.txt
> @@ -310,7 +310,7 @@ that support this feature.
>      loaded to random addresses. Also for PIE-linked binaries, the location
>      of code start is randomized.
>  
> -    With heap randomization, the situation is a little bit more
> +2 - With heap randomization, the situation is a little bit more
>      complicated.
>      There a few legacy applications out there (such as some ancient

... would you please fix this typo/grammo as well? (There a few ...)

>      versions of libc.so.5 from 1996) that assume that brk area starts

Also, the text itself doesn't seem to be super-clear ... namely, it 
describes what CONFIG_COMPAT_BRK is about, but doesn't really clarify how 
exactly does this correlate with randomize_va_space == 2. Would you mind 
also fixing this bit?

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/