Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756949AbZGCAPW (ORCPT ); Thu, 2 Jul 2009 20:15:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754864AbZGCAPJ (ORCPT ); Thu, 2 Jul 2009 20:15:09 -0400 Received: from mail.samba.org ([66.70.73.150]:47335 "EHLO lists.samba.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752947AbZGCAPI (ORCPT ); Thu, 2 Jul 2009 20:15:08 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19021.19842.663727.146474@samba.org> Date: Fri, 3 Jul 2009 10:14:58 +1000 To: Jan Engelhardt Cc: Theodore Tso , Alan Cox , Rusty Russell , Pavel Machek , OGAWA Hirofumi , john.lanza@linux.com, Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, Dave Kleikamp , corbet@lwn.net, jcm@jonmasters.org Subject: Re: CONFIG_VFAT_FS_DUALNAMES regressions In-Reply-To: References: <19013.8005.541836.436991@samba.org> <20090630063102.GB1351@ucw.cz> <200907012019.53932.rusty@rustcorp.com.au> <20090701122558.3a7c80d3@lxorguk.ukuu.org.uk> <20090701140503.GA21185@mit.edu> X-Mailer: VM 8.0.12 under 22.2.1 (x86_64-pc-linux-gnu) Reply-To: tridge@samba.org From: tridge@samba.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1649 Lines: 34 Hi Jan, I should also mention that in the first patch I sent back in May, I added some code that made the 8.3 name problem easier on the user. It basically forced the shortname= option, overriding the mount option, when the patch was triggered. The end result was that a name like dcis3000.jpg would always be stored as a 8.3 name, and thus be visible to digital cameras, even if the mount options were set to say that lowercase names should be considered as "long" names. Hirofumi objected, on the basis that I was overriding the VFAT mount option. I think that overriding in this case would in fact be worthwhile, as I don't think many users ever think carefully about what shortname= option they are using, and unless you get it right then you can get some real surprises. Hirofumi-san, do you think that same objection you expressed previously also applies to this new patch? For example, would you think it reasonable to modify the patch to store the filename as 8.3 if it can fit in 8.3 in a case mapped manner? Or store as 8.3 if it is all uppercase or all lowercase? I think we will hit cases like the one Jan has pointed out where the exising shortname= options will become even more confusing than they were already when this new patch is applied, especially as I think most distros these days magically supply a shortname= option when you insert some VFAT formatted media. Cheers, Tridge -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/