Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756316AbZGCAZb (ORCPT ); Thu, 2 Jul 2009 20:25:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755760AbZGCAZV (ORCPT ); Thu, 2 Jul 2009 20:25:21 -0400 Received: from mail.samba.org ([66.70.73.150]:47665 "EHLO lists.samba.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754004AbZGCAZU (ORCPT ); Thu, 2 Jul 2009 20:25:20 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19021.20449.732095.210252@samba.org> Date: Fri, 3 Jul 2009 10:25:05 +1000 To: Jan Engelhardt Cc: Theodore Tso , Alan Cox , Rusty Russell , Pavel Machek , OGAWA Hirofumi , john.lanza@linux.com, Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, Dave Kleikamp , corbet@lwn.net, jcm@jonmasters.org Subject: Re: CONFIG_VFAT_FS_DUALNAMES regression In-Reply-To: References: <19013.8005.541836.436991@samba.org> <20090630063102.GB1351@ucw.cz> <200907012019.53932.rusty@rustcorp.com.au> <20090701122558.3a7c80d3@lxorguk.ukuu.org.uk> <20090701140503.GA21185@mit.edu> <19021.17576.808138.476600@samba.org> X-Mailer: VM 8.0.12 under 22.2.1 (x86_64-pc-linux-gnu) Reply-To: tridge@samba.org From: tridge@samba.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1727 Lines: 50 Hi Jan, > Then, I just tried everything to get an overview: thanks! > (All with DUALNAMES=n) > # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=lower > # cp /mnt/dcim/100_fuji/dscf{4160,3004}.jpg > # umount /mnt > # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=win95 > # cp /mnt/dcim/100_fuji/dscf{4160,3005}.jpg > # umount /mnt > # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=winnt > # cp /mnt/dcim/100_fuji/dscf{4160,3006}.jpg > # umount /mnt > # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=mixed > # cp /mnt/dcim/100_fuji/dscf{4160,3007}.jpg > # umount /mnt > > Result? The camera only displays 3006. > > The dualnames patch's filling filenames with random illegal > chars does seems to have a really foul side-effect after actually, you've just proved the patch works as intended on your device! Only the shortname=winnt would create a 8.3 name when you use the filename dscfNNNN.jpg. That is why my first patch in May forced shortname_flags = VFAT_SFN_CREATE_WINNT; when the patch triggered. I think this is the only sane behaviour for a VFAT filesystem on Linux. Unfortunately it isn't the default, and at least on my Ubuntu system the automatic mounting doesn't get this right. I'd love to change the default or do an override, at least when dualnames is diabled. Hirofumi-san, what do you think? Cheers, Tridge PS: I'm assuming you actually typed "shortname=" not "shortnames=". The option is not plural. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/