Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbZGCH3y (ORCPT ); Fri, 3 Jul 2009 03:29:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751418AbZGCH3r (ORCPT ); Fri, 3 Jul 2009 03:29:47 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:57073 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbZGCH3r (ORCPT ); Fri, 3 Jul 2009 03:29:47 -0400 Date: Fri, 3 Jul 2009 09:29:41 +0200 From: Ingo Molnar To: Mike Galbraith Cc: Arnaldo Carvalho de Melo , Paul Mackerras , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , LKML , Peter Zijlstra Subject: Re: [patch 0/4] perf_counter tools: support annotation of live kernel modules Message-ID: <20090703072941.GC7943@elte.hu> References: <1246514639.13293.40.camel@marge.simson.net> <20090702064712.GA26690@elte.hu> <1246519076.6384.22.camel@marge.simson.net> <1246524170.7113.20.camel@marge.simson.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246524170.7113.20.camel@marge.simson.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 31 * Mike Galbraith wrote: > On Thu, 2009-07-02 at 09:17 +0200, Mike Galbraith wrote: > > > After I resurrect (well, try) live annotation in top... > > Random thought wrt live top annotation: instead of resurrecting in > the previous form, which could be a bit intrusive display space > wise, what do you think of this idea? > > Provide a kbd input snapshot trigger which builds a perf record > (hard?) compatible file for the symbols being displayed. Start a > background task to annotate the lot, stuffing annotate output into > an output file. > > Better ideas highly welcome. Hm, is there really a performance problem? We need to calculate and cache the objdump annotation output once, but after that it should be pretty fast as we just display updated counts with the same lines over and over again. No repeated objdump runs are needed. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/