Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753803AbZGCHvw (ORCPT ); Fri, 3 Jul 2009 03:51:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753037AbZGCHvm (ORCPT ); Fri, 3 Jul 2009 03:51:42 -0400 Received: from mx2.redhat.com ([66.187.237.31]:47875 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346AbZGCHvm (ORCPT ); Fri, 3 Jul 2009 03:51:42 -0400 Date: Fri, 3 Jul 2009 09:51:40 +0200 From: Jiri Olsa To: Jarek Poplawski Cc: Davide Libenzi , Eric Dumazet , netdev@vger.kernel.org, Linux Kernel Mailing List , fbl@redhat.com, nhorman@redhat.com, davem@redhat.com, htejun@gmail.com, oleg@redhat.com Subject: Re: [PATCHv4 2/2] memory barrier: adding smp_mb__after_lock Message-ID: <20090703075140.GD2902@jolsa.lab.eng.brq.redhat.com> References: <20090702063259.GA3429@jolsa.lab.eng.brq.redhat.com> <20090702063624.GC3429@jolsa.lab.eng.brq.redhat.com> <4A4C5983.7000501@gmail.com> <20090703074126.GB2902@jolsa.lab.eng.brq.redhat.com> <20090703074730.GB4847@ff.dom.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090703074730.GB4847@ff.dom.local> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1498 Lines: 48 On Fri, Jul 03, 2009 at 07:47:31AM +0000, Jarek Poplawski wrote: > On Fri, Jul 03, 2009 at 09:41:26AM +0200, Jiri Olsa wrote: > > On Thu, Jul 02, 2009 at 07:39:04AM -0700, Davide Libenzi wrote: > > > On Thu, 2 Jul 2009, Eric Dumazet wrote: > > > > > > > Jiri Olsa a ?crit : > > > > > Adding smp_mb__after_lock define to be used as a smp_mb call after > > > > > a lock. > > > > > > > > > > Making it nop for x86, since {read|write|spin}_lock() on x86 are > > > > > full memory barriers. > > > > > > > > > > wbr, > > > > > jirka > > > > > > > > > > > > > > > Signed-off-by: Jiri Olsa > > > > > > > > > > > > Maybe we should remind that sk_has_helper() is always called > > > > right after a call to read_lock() as in : > > > > > > > > read_lock(&sk->sk_callback_lock); > > > > if (sk_has_sleeper(sk)) > > > > wake_up_interruptible_all(sk->sk_sleep); > > > > > > Agreed, that'd be to have it in the source code comment. > > > > > > > > > - Davide > > > > > > > ok, I'll add it to the 1/2 part in v5 > > > > Btw., there is a tiny typo: > > - receive callbacks. Adding fuctions sock_poll_wait and sock_has_sleeper > + receive callbacks. Adding fuctions sock_poll_wait and sk_has_sleeper > > Jarek P. thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/