Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754768AbZGCIiR (ORCPT ); Fri, 3 Jul 2009 04:38:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752608AbZGCIiF (ORCPT ); Fri, 3 Jul 2009 04:38:05 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:62533 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752246AbZGCIiE (ORCPT ); Fri, 3 Jul 2009 04:38:04 -0400 Message-ID: <4A4DC358.7030900@cn.fujitsu.com> Date: Fri, 03 Jul 2009 16:37:44 +0800 From: Gui Jianfeng User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Li Zefan CC: Paul Menage , linux-kernel@vger.kernel.org, Linux Containers Subject: Re: [PATCH] cgroup: Fix indent for /proc/cgroups References: <4A4DBBC2.8010805@cn.fujitsu.com> <4A4DBF50.8090408@cn.fujitsu.com> In-Reply-To: <4A4DBF50.8090408@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 55 Li Zefan wrote: > CC: container list > > Gui Jianfeng wrote: >> Currently, /proc/cgroups outputs is fairly ugly as following, >> #subsys_name hierarchy num_cgroups enabled >> cpuset 0 1 1 >> debug 0 1 1 >> ns 0 1 1 >> >> indent it in a good-looking way. >> #subsys_name hierarchy num_cgroups enabled >> cpuset 0 1 1 >> debug 0 1 1 >> ns 0 1 1 >> > > But if there's a subsystem with name length >= 8, > it won't be aligned properly.. Yeap, but there isn't such a case at least by now. > >> Signed-off-by: Gui Jianfeng >> --- >> kernel/cgroup.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/kernel/cgroup.c b/kernel/cgroup.c >> index 3737a68..99fc160 100644 >> --- a/kernel/cgroup.c >> +++ b/kernel/cgroup.c >> @@ -2963,7 +2963,7 @@ static int proc_cgroupstats_show(struct seq_file *m, void *v) >> mutex_lock(&cgroup_mutex); >> for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) { >> struct cgroup_subsys *ss = subsys[i]; >> - seq_printf(m, "%s\t%lu\t%d\t%d\n", >> + seq_printf(m, "%s\t\t%lu\t\t%d\t\t%d\n", >> ss->name, ss->root->subsys_bits, >> ss->root->number_of_cgroups, !ss->disabled); >> } > > > > -- Regards Gui Jianfeng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/