Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756248AbZGCJk2 (ORCPT ); Fri, 3 Jul 2009 05:40:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754889AbZGCJkO (ORCPT ); Fri, 3 Jul 2009 05:40:14 -0400 Received: from tundra.namei.org ([65.99.196.166]:37480 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754213AbZGCJkM (ORCPT ); Fri, 3 Jul 2009 05:40:12 -0400 Date: Fri, 3 Jul 2009 19:39:22 +1000 (EST) From: James Morris To: Oleg Nesterov cc: Andrew Morton , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, David Howells , Roland McGrath Subject: Re: [PATCH] selinux_bprm_committed_creds: use __wake_up_parent() In-Reply-To: <20090703092311.GA3712@redhat.com> Message-ID: References: <200906301951.n5UJpUSY013305@imap1.linux-foundation.org> <11314.1246585948@turing-police.cc.vt.edu> <20090702192047.10b81ada.akpm@linux-foundation.org> <20090703081821.GA4051@redhat.com> <20090703092311.GA3712@redhat.com> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 37 On Fri, 3 Jul 2009, Oleg Nesterov wrote: > (depends on ptrace-__ptrace_detach-do-__wake_up_parent-if-we-reap-the-tracee.patch > which exports __wake_up_parent) > > Spotted by Valdis.Kletnieks@vt.edu. > > selinux_bprm_committed_creds() should not play with ->wait_chldexit, now > that __wake_up_parent() is exported change the code to use this helper. > > Signed-off-by: Oleg Nesterov Acked-by: James Morris > > --- WAIT/security/selinux/hooks.c~SEL_WAKE_PARENT 2009-06-16 17:01:42.000000000 +0200 > +++ WAIT/security/selinux/hooks.c 2009-07-03 11:15:08.000000000 +0200 > @@ -2404,7 +2404,7 @@ static void selinux_bprm_committed_creds > /* Wake up the parent if it is waiting so that it can recheck > * wait permission to the new task SID. */ > read_lock(&tasklist_lock); > - wake_up_interruptible(¤t->real_parent->signal->wait_chldexit); > + __wake_up_parent(current, current->real_parent); > read_unlock(&tasklist_lock); > } > > -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/