Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756793AbZGCK0i (ORCPT ); Fri, 3 Jul 2009 06:26:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754403AbZGCK03 (ORCPT ); Fri, 3 Jul 2009 06:26:29 -0400 Received: from cantor.suse.de ([195.135.220.2]:37433 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413AbZGCK02 (ORCPT ); Fri, 3 Jul 2009 06:26:28 -0400 Date: Fri, 3 Jul 2009 12:26:31 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@wotan.suse.de To: Ingo Molnar Cc: Horst Schirmeier , rdunlap@xenotime.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] doc: missing value 2 for randomize-va-space In-Reply-To: <20090703102431.GC32128@elte.hu> Message-ID: References: <20090702152338.GU26384@quickstop.soohrt.org> <20090703000523.GX26384@quickstop.soohrt.org> <20090703102431.GC32128@elte.hu> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1849 Lines: 50 On Fri, 3 Jul 2009, Ingo Molnar wrote: > > > > > There a few legacy applications out there (such as some ancient > > > > > > > > ... would you please fix this typo/grammo as well? (There a few ...) > > > > > > > > > versions of libc.so.5 from 1996) that assume that brk area starts > > > > > > > > Also, the text itself doesn't seem to be super-clear ... namely, it > > > > describes what CONFIG_COMPAT_BRK is about, but doesn't really clarify how > > > > exactly does this correlate with randomize_va_space == 2. Would you mind > > > > also fixing this bit? > > > > > > I hope I didn't misread the sources :-) Opinions? > > > > > > --- > > > > > > The documentation for /proc/sys/kernel/* does not mention the possible > > > value 2 for randomize-va-space yet. While being there, doing some > > > reformatting, fixing grammar problems and clarifying the correlations > > > between randomize-va-space, kernel parameter "norandmaps" and the > > > CONFIG_COMPAT_BRK option. > > > > > > Signed-off-by: Horst Schirmeier > > > > Acked-by: Jiri Kosina > > > > Ingo, will you take this through your tree? > > > > > > > > --- > > > Documentation/sysctl/kernel.txt | 30 +++++++++++++++++------------- > > > 1 files changed, 17 insertions(+), 13 deletions(-) > > This could go to your or Randy's docs tree, right? (would be fine by > me) Sure, I basically just wanted your ACK, as you were the last one touching the respective code. I will queue it, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/