Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755371AbZGCNE5 (ORCPT ); Fri, 3 Jul 2009 09:04:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753087AbZGCNEu (ORCPT ); Fri, 3 Jul 2009 09:04:50 -0400 Received: from mail.atmel.fr ([81.80.104.162]:44842 "EHLO atmel-es2.atmel.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbZGCNEu (ORCPT ); Fri, 3 Jul 2009 09:04:50 -0400 Message-ID: <4A4E01BF.8040209@atmel.com> Date: Fri, 03 Jul 2009 15:03:59 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: "Sosnowski, Maciej" CC: "Williams, Dan J" , "avictor.za@gmail.com" , "linux-arm-kernel@lists.arm.linux.org.uk" , "patrice.vilchez@atmel.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2 v2] dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller References: <1246012936-10812-1-git-send-email-nicolas.ferre@atmel.com> <129600E5E5FB004392DDC3FB599660D7AF555E87@irsmsx504.ger.corp.intel.com> In-Reply-To: <129600E5E5FB004392DDC3FB599660D7AF555E87@irsmsx504.ger.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1883 Lines: 44 Sosnowski, Maciej : > Nicolas Ferre wrote: >> This AHB DMA Controller (aka HDMA or DMAC on AT91 systems) is availlable on >> at91sam9rl chip. It will be used on other products in the future. >> >> This first release covers only the memory-to-memory tranfer type. This is the >> only tranfer type supported by this chip. On other products, it will be used >> also for peripheral DMA transfer (slave API support to come). >> >> I used dmatest client without problem in different configurations to test it. >> >> Full documentation for this controller can be found in the SAM9RL datasheet: >> http://www.atmel.com/dyn/products/product_card.asp?part_id=4243 >> >> Signed-off-by: Nicolas Ferre >> --- > [...] >> + /* >> + * We use dma_unmap_page() regardless of how the buffers were >> + * mapped before they were submitted... >> + */ >> + if (!(txd->flags & DMA_COMPL_SKIP_DEST_UNMAP)) >> + dma_unmap_page(chan2parent(&atchan->chan_common), desc->lli.daddr, >> + desc->len, DMA_FROM_DEVICE); >> + if (!(txd->flags & DMA_COMPL_SKIP_SRC_UNMAP)) >> + dma_unmap_page(chan2parent(&atchan->chan_common), desc->lli.saddr, >> + desc->len, DMA_TO_DEVICE); > > It is similar issue as the one fixed in 2.6.30 by 'ioatdma: fix "ioatdma frees DMA memory with wrong function"' patch: > commit 4f005dbe5584fe54c9f6d6d4f0acd3fb29be84da. > Note that this patch introduces dma control flags: DMA_COMPL_SRC_UNMAP_SINGLE and DMA_COMPL_DEST_UNMAP_SINGLE, > that could be used by the driver to choose proper unmapping. Sure Maciej, I correct this in my v3 patch (already done locally BTW). Kind regards, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/