Date: Fri, 3 Jul 2009 12:10:23 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
cc: Eric Dumazet <eric.dumazet@gmail.com>, mingo@redhat.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH -tip] x86: atomic64: inline atomic64_read()
In-Reply-To: <20090703180450.GB3405@elte.hu>
Message-ID: <alpine.LFD.2.01.0907031207030.3210@localhost.localdomain>
References: <alpine.LFD.2.01.0907021653030.3210@localhost.localdomain> <tip-9103cab145a93cef13378632b332a824758a2f6f@git.kernel.org> <4A4E1AA2.30002@gmail.com> <20090703180450.GB3405@elte.hu>
User-Agent: Alpine 2.01 (LFD 1184 2008-12-16)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1163
Lines: 35


On Fri, 3 Jul 2009, Ingo Molnar wrote:
> > +
> > +	asm volatile(
> > +		"mov %%ebx, %%eax\n\t"
> > +		"mov %%ecx, %%edx\n\t"
> > +		LOCK_PREFIX "cmpxchg8b %1\n"
> > +			: "=&A" (res)
> > +			: "m" (*ptr) 
> > +		);
> 
> That clobbers or affects eax, ebx, ecx, edx. The only registers it 
> does not clobber is esi, edi and rbp.

No, it only clobbers eax/edx. Yes, it touches ebx/ecx, but that's kind of 
incidental, and read-only, and doesn't matter.

> Linus, what's your preference in this case?

I think it's kind of subtle to do that thing, but it _is_ very much a 
special case. It's odd to use a cmpxchg8b to just do a read in the first 
place, so the fact that we then play other games with it is kind of 
immaterial.

Adding a comment about the magic "we don't care about the initial values 
in eax/edx and ebx/ecx, but they have to match in case we end up doing a 
writeback" might be a good idea.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/