Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757076AbZGEO5Y (ORCPT ); Sun, 5 Jul 2009 10:57:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754727AbZGEO5Q (ORCPT ); Sun, 5 Jul 2009 10:57:16 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42376 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753995AbZGEO5P (ORCPT ); Sun, 5 Jul 2009 10:57:15 -0400 Date: Sun, 5 Jul 2009 07:56:56 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Paul Mundt cc: Wu Zhangjin , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Krzysztof Helt , Peter Zijlstra , "Rafael J. Wysocki" , Andrew Morton , Ralf Baechle , ???? , zhangfx Subject: Re: [BUG] drivers/video/sis: deadlock introduced by "fbdev: add mutex for fb_mmap locking" In-Reply-To: <20090705145203.GA8326@linux-sh.org> Message-ID: References: <1246785112.14240.34.camel@falcon> <20090705145203.GA8326@linux-sh.org> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 422 Lines: 16 On Sun, 5 Jul 2009, Paul Mundt wrote: > break; > fb_info->node = i; > mutex_init(&fb_info->lock); > - mutex_init(&fb_info->mm_lock); Why not "lock" as well? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/