References: <20090705135806.GB9778@liondog.tnic>
Message-ID: <cone.1246812673.209196.4691.1000@onepiie>
From: Peter Feuerer <peter@piie.net>
To: Borislav Petkov <petkovbb@googlemail.com>
Cc: Len Brown <lenb@kernel.org>, linux-kernel@vger.kernel.org,
       Andreas Mohr <andi@lisas.de>
Subject: Re: [PATCH] Acerhdf: fix fan control for BIOS 3309
Date: Sun, 05 Jul 2009 18:51:13 +0200
Mime-Version: 1.0
Content-Type: text/plain; format=flowed; charset="US-ASCII"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1893
Lines: 48

Hi Boris,

Borislav Petkov writes:

> Hi Len,
> 
> please apply.
> 
> ---
> From: Borislav Petkov <petkovbb@gmail.com>
> Date: Sun, 5 Jul 2009 14:35:01 +0200
> Subject: [PATCH] Acerhdf: fix fan control for BIOS 3309
> 
> With BIOS update v3309, the Aspire One has had some changes to how
> the fan is being controlled. Reads to the fanreg (0x55) do not simply
> return the on/off values of the fan anymore but rather a different
> fan stage based on the current temperature. Empirically, I could
> observe the fan stage being 0x1 when booting the machine, then the
> temperature went up and the BIOS switched the fan to stage 0x2, making
> it rotate faster with final stage being fan state 0x3, aka max.

I think it was already like that before v3309. But in my opinion it doesn't 
matter how fast the fan spins. As soon as it's spinning it's making too much 
noise. That's why I like to use only two states for the fan, "on" (noisy, 
doesn't matter how fast it's spinning) and "off" (quiet ;))

> This requires some changes to the controlling code so that it can still
> be done adequately. Also, the OFF switch has changed from 0x21 to 0x20.
> It seems almost as if they're using the least significant nibble of the
> command written to the ioport for the different fan stages.

I've been developping acerhdf with BIOS v3309 since the very beginning. And 
it was working fine with 0x21 all the time. I'm going to do some further 
inverstigations next few days. Thanks for reporting!

> 
> While at it, convert the fancmd[] array to a real struct thus
> disambiguating command handling and making code more readable.

Good!

kind regards,
--peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/