Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757978AbZGFI0m (ORCPT ); Mon, 6 Jul 2009 04:26:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753668AbZGFI0e (ORCPT ); Mon, 6 Jul 2009 04:26:34 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:55098 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753406AbZGFI0d (ORCPT ); Mon, 6 Jul 2009 04:26:33 -0400 From: Arnd Bergmann To: FUJITA Tomonori Subject: Re: [PATCH 2/5] sparc: use asm-generic/dma-mapping-common.h Date: Mon, 6 Jul 2009 10:26:28 +0200 User-Agent: KMail/1.12.0 (Linux/2.6.30-9-generic; KDE/4.2.95; x86_64; ; ) Cc: davem@davemloft.net, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, reif@earthlink.net References: <1246860820-20629-1-git-send-email-fujita.tomonori@lab.ntt.co.jp> <1246860820-20629-3-git-send-email-fujita.tomonori@lab.ntt.co.jp> In-Reply-To: <1246860820-20629-3-git-send-email-fujita.tomonori@lab.ntt.co.jp> X-Face: I@=L^?./?$U,EK.)V[4*>`zSqm0>65YtkOe>TFD'!aw?7OVv#~5xd\s,[~w]-J!)|%=]> =?utf-8?q?+=0A=09=7EohchhkRGW=3F=7C6=5FqTmkd=5Ft=3FLZC=23Q-=60=2E=60Y=2Ea=5E?= =?utf-8?q?3zb?=) =?utf-8?q?+U-JVN=5DWT=25cw=23=5BYo0=267C=26bL12wWGlZi=0A=09=7EJ=3B=5Cwg?= =?utf-8?q?=3B3zRnz?=,J"CT_)=\H'1/{?SR7GDu?WIopm.HaBG=QYj"NZD_[zrM\Gip^U MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200907061026.28878.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX192dS9mKdNdjEWCH2VSs/NXUj9LcDEyNZLtmQl RIiTCpklySRjX61cBH1QhyL/xotp4a2XWFssW4BVcW8o4tiJel UJq8FN3zWx1XaQyOKS7EgY2nKH/EJZ1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 785 Lines: 24 On Monday 06 July 2009, FUJITA Tomonori wrote: > +static inline struct dma_map_ops *get_dma_ops(struct device *dev) > +{ > + return dma_ops; > +} > + > +#define flush_write_buffers() > + > +#include I still think the flush_write_buffers() x86-ism should not be required to use dma-mapping-common.h and only be used in arch/x86/kernel/pci-nommu.c so you don't have to add dummy definitions to all architectures. See http://lkml.org/lkml/2009/6/30/134 Otherwise, your series looks good! Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/